Temp revocation should use opposing type

[Zabuzard]

Overview

Fixes and closes #371.

Revocations of temporary moderation actions (such as temp bans) have to be logged with the opposing action type (unban) in the /audit command:

Details

The relevant section in the code is TemporaryModerationRoutine.java#130:

actionsStore.addAction(
  guild.getIdLong(),
  jda.getSelfUser().getIdLong(),
  target.getIdLong(),
  actionType, // <--- should be UNBAN not BAN
  null,
  reason);

The opposing type information already exists and can be grabbed from the RevocableModerationAction computed in the next line, such as:

var action = getRevocableActionByType(actionType);
var opposingType = action.getRevokeType();
...

So we just moved the line above and use the getRevokeType() instead now.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication