Skip to content

Update Logviewer Dependencies #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zabuzard wants to merge 1 commit into from
Closed

Update Logviewer Dependencies #310

Zabuzard wants to merge 1 commit into from

Conversation

@Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Dec 10, 2021 •
edited
Loading

Merged from several Dependabot PRs

Checklist

  • Wait until EnhancedDialog is compatible with 22. See this.

@Zabuzard
Update Logviewer Dependencies
6bbfbaf 
Merged from several Dependabot PRs
* vaadin-core: 21.0.2 -> 22.0.0 (#294)
* com.vaadin: 21.0.2 -> 22.0.0 (#293)
* crudui: 4.6.0 -> 5.0.0 ( #291)
* vaadin-spring: 18.0.0 -> 19.0.0 (#289)
@Zabuzard Zabuzard added the dependencies Pull requests that update a dependency file label Dec 10, 2021
@Zabuzard Zabuzard requested a review from krankkkk December 10, 2021 07:55
@Zabuzard Zabuzard requested review from a team as code owners December 10, 2021 07:55
This was referenced Dec 10, 2021
Closed
Closed
Closed
Closed
Zabuzard
Zabuzard commented Dec 10, 2021
View reviewed changes
Copy link
Member Author

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krankkkk Found out an issue with this:

Some of the Upgrades break the viewer, blocking while I investigate...
Edit: EnhancedDialog not yet compatible with 22. See this

Hence, blocked for the meantime.

@Zabuzard Zabuzard added the blocked This issue is currently blocked by another issue (see comments) label Dec 10, 2021
@Zabuzard
Copy link
Member Author

Zabuzard commented Dec 15, 2021 •
edited
Loading

@krankkkk Is this obsolete now that #324 has been merged? Or unrelated?

@krankkkk
Copy link
Contributor

krankkkk commented Dec 15, 2021 •
edited
Loading

@krankkkk Is this obsolete now that #324 has been merged? Or unrelated?

Unrelated, this is vaadin itself

@github-actions
Copy link

github-actions bot commented Jan 15, 2022

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added stale inactivity-closed Issues that have been closed due to inactivity, but are otherwise valid and might be reopened later labels Jan 15, 2022
@github-actions github-actions bot closed this Jan 20, 2022
@Zabuzard Zabuzard deleted the feature/update_logviewer_deps branch March 17, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Heatmanofurioso Heatmanofurioso Heatmanofurioso approved these changes

@krankkkk krankkkk Awaiting requested review from krankkkk

Assignees

@krankkkk krankkkk

Labels

blocked This issue is currently blocked by another issue (see comments) dependencies Pull requests that update a dependency file inactivity-closed Issues that have been closed due to inactivity, but are otherwise valid and might be reopened later stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zabuzard @krankkkk @Heatmanofurioso