Skip to content

Adding tag used in the footer #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zabuzard merged 12 commits into from
Dec 29, 2021
Merged

Adding tag used in the footer #309

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef404c8
This is a pull request on resolving the issue#275, The issue was reso…
DevSerendipity Dec 8, 2021
8e15c4d
Sollution to improving the footer reply
DevSerendipity Dec 8, 2021
4baa29f
Removed the generate embed method from MessageUtils.java and added t…
DevSerendipity Dec 10, 2021
3ee5423
Another comment of previous generate embed class
DevSerendipity Dec 10, 2021
463d53d
Removed the redundant comments, the setAuthor method and added the ti…
DevSerendipity Dec 10, 2021
c09b4ca
Removed the additional comment, reverted back to an old call and chan…
DevSerendipity Dec 10, 2021
e512ffa
Removing, the usertoString and replacing it with user.getName
DevSerendipity Dec 10, 2021
2d2c980
Removing the empty line
DevSerendipity Dec 10, 2021
6381594
Applied spotless
DevSerendipity Dec 10, 2021
2bc4e8a
Merge branch 'develop' into feature/replicating-slash-command
DevSerendipity Dec 11, 2021
abde994
Removed the Todo comment
DevSerendipity Dec 20, 2021
c85473a
Pulled the changes from the origin branch and ran spotless
DevSerendipity Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion application/src/main/java/org/togetherjava/tjbot/commands/free/FreeCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public void displayStatus(@NotNull TextChannel channel) {

String messageTxt = buildStatusMessage(guild);
MessageEmbed embed = MessageUtils.generateEmbed(STATUS_TITLE, messageTxt,
channel.getJDA().getSelfUser(), MESSAGE_HIGHLIGHT_COLOR);
channel.getJDA().getSelfUser(), MESSAGE_HIGHLIGHT_COLOR, null);

getStatusMessageIn(channel).flatMap(this::deleteIfNotLatest)
.ifPresentOrElse(message -> message.editMessageEmbeds(embed).queue(),
Expand Down
12 changes: 8 additions & 4 deletions application/src/main/java/org/togetherjava/tjbot/commands/tags/TagCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package org.togetherjava.tjbot.commands.tags;

import net.dv8tion.jda.api.entities.MessageEmbed;
import net.dv8tion.jda.api.entities.User;
import net.dv8tion.jda.api.events.interaction.SlashCommandEvent;
import net.dv8tion.jda.api.interactions.commands.OptionType;
import org.jetbrains.annotations.NotNull;
Expand Down Expand Up @@ -43,9 +45,11 @@ public void onSlashCommand(@NotNull SlashCommandEvent event) {
return;
}

event
.replyEmbeds(MessageUtils.generateEmbed(null, tagSystem.getTag(id).orElseThrow(),
event.getUser(), TagSystem.AMBIENT_COLOR))
.queue();
event.replyEmbeds(tagEmbed(id, event.getUser(), event.getCommandString())).queue();
}

private MessageEmbed tagEmbed(String id, User user, String commandString) {
return MessageUtils.generateEmbed(null, tagSystem.getTag(id).orElseThrow(), user,
TagSystem.AMBIENT_COLOR, user.getName() + " " + commandString);
}
}
9 changes: 5 additions & 4 deletions application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@ public TagManageCommand(TagSystem tagSystem) {
private static void sendSuccessMessage(@NotNull Interaction event, @NotNull String id,
@NotNull String actionVerb) {
logger.info("User '{}' {} the tag with id '{}'.", event.getUser().getId(), actionVerb, id);
event.replyEmbeds(MessageUtils.generateEmbed("Success",
"Successfully %s tag '%s'.".formatted(actionVerb, id), event.getUser(),
TagSystem.AMBIENT_COLOR))
event
.replyEmbeds(MessageUtils.generateEmbed("Success",
"Successfully %s tag '%s'.".formatted(actionVerb, id), event.getUser(),
TagSystem.AMBIENT_COLOR, null))
.queue();
}

Expand Down Expand Up @@ -149,7 +150,7 @@ private void rawTag(@NotNull SlashCommandEvent event) {

event.replyEmbeds(MessageUtils.generateEmbed(null,
MessageUtils.escapeMarkdown(tagSystem.getTag(id).orElseThrow()), event.getUser(),
TagSystem.AMBIENT_COLOR))
TagSystem.AMBIENT_COLOR, null))
.queue();
}

Expand Down
6 changes: 4 additions & 2 deletions application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@ public TagsCommand(TagSystem tagSystem) {
@Override
public void onSlashCommand(@NotNull SlashCommandEvent event) {
// TODO A list might be better than comma separated, which is hard to read
event.replyEmbeds(MessageUtils.generateEmbed("All available tags",
String.join(", ", tagSystem.getAllIds()), event.getUser(), TagSystem.AMBIENT_COLOR))
event
.replyEmbeds(MessageUtils.generateEmbed("All available tags",
String.join(", ", tagSystem.getAllIds()), event.getUser(),
TagSystem.AMBIENT_COLOR, null))
.addActionRow(
TagSystem.createDeleteButton(generateComponentId(event.getUser().getId())))
.queue();
Expand Down
5 changes: 3 additions & 2 deletions application/src/main/java/org/togetherjava/tjbot/commands/utils/MessageUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,12 @@ public static void disableButtons(@NotNull Message message) {
* @return the generated embed
*/
public static @NotNull MessageEmbed generateEmbed(@Nullable String title,
@NotNull CharSequence content, @Nullable User user, @Nullable Color ambientColor) {
@NotNull CharSequence content, @Nullable User user, @Nullable Color ambientColor,
@Nullable String footer) {
return new EmbedBuilder().setTitle(title)
.setDescription(content)
.setTimestamp(Instant.now())
.setFooter(user == null ? null : user.getName())
.setFooter(user == null ? null : user.getName() + " " + footer)
.setColor(ambientColor)
.build();
}
Expand Down