Refactor array-loading methods, add tests#361
Merged
mwtoews merged 1 commit intoToblerity:mainfrom Mar 28, 2025
Merged
Conversation
4406065 to
c4dcd3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the newly added
intersection_vandnearest_vfunctions, and adds some tests.atleast_1dandatleast_2dfunctions to sanitise inputs for ctypesassertchecks with more verbose checks that raise ValueError, checking dimensions, shape and stridesnearest_vto enforce keyword-only fromnum_results; this function is new, so I don't anticipate this change will be disruptive. Note thatnearestdoes not enforce keyword-only fromnum_results, but this could change in a future release through a deprecation process.