[FEAT]: Add support for multithreading to improve performance #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssassi
changed the title
ssassi
changed the title
ssassi
changed the title
ssassi
had a problem deploying
to
snowflake-aws-standard
GitHub Actions
Failure
ssassi
had a problem deploying
to
snowflake-aws-enterprise
GitHub Actions
Failure
ssassi
had a problem deploying
to
snowflake-aws-business-critical
GitHub Actions
Failure
ssassi
had a problem deploying
to
snowflake-azure-standard
GitHub Actions
Failure
ssassi
had a problem deploying
to
snowflake-gcp-standard
GitHub Actions
Failure
Collaborator
|
I'll have to figure out how to get test connection auth running properly for non-core contributors. Interesting PR. AI edits removed a bunch of comments unfortunately. |
added 4 commits
March 13, 2025 09:55
…hreading * 'main' of github.com:datacoves/titan: Bump version: 0.11.3 → 0.11.4 Update README to include key pair auth details (Titan-Systems#201)
ssassi
changed the title
Author
|
I've tested it deeper and fixed some bugs while running on sync mode. Also restored comments changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After testing titan on a large data set of roles and users I concluded that multithreading is key to make the tool usable.
On my tests, it took ~1 hour to create 3000 roles and 1000 users, including user grants.
This scenario could be normal on enterprise.
Solution
This PR adds multithreading, defaulting to 8 threads. I kept the dynamic role switching, and introduced the computation of execution levels to run the sql statements in the correct order.
On my tests, the same resources were created in ~8 minutes.
NOTE: I created this over the weekend and of course needs testing, take this as a draft PR to start reviewing/improving.