Skip to content

fix: update resource name handling and identifier parsing for emails/login_name for Users #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update resource name handling and identifier parsing for emails/login_name for Users #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6a1ac3
fix: update resource name handling and identifier parsing for emails
ike-lacey Feb 26, 2025
1d63bc4
Merge branch 'main' into main
ike-lacey Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_identifiers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ def test_resource_name():
assert rn._quoted

rn = ResourceName("[email protected]")
assert str(rn) == '"[email protected]"'
assert rn._quoted
assert str(rn) == "[email protected]"
assert not rn._quoted


def test_resource_name_equality():
Expand Down
2 changes: 1 addition & 1 deletion titan/parse_primitives.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pyparsing as pp

Identifier = pp.Word(pp.alphanums + "_", pp.alphanums + "_$") | pp.dbl_quoted_string
Identifier = pp.Word(pp.alphanums + "_@", pp.alphanums + "_@$") | pp.dbl_quoted_string
FullyQualifiedIdentifier = (
pp.delimited_list(Identifier, delim=".", min=4, max=4)
^ pp.delimited_list(Identifier, delim=".", min=3, max=3)
Expand Down