-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add geospatial plugin #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add geospatial plugin #7406
Changes from 250 commits
Commits
Show all changes
543 commits
Select commit
Hold shift + click to select a range
1dea0a0
Merge branch 'master' into parameterised-transclusions
Jermolene 6a9de97
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 176560d
Add XLSX import spec for demo real estate spreadsheets
Jermolene 21ba5c5
Fix fieldname
Jermolene 7278cc6
Improve map pin
Jermolene 86569e5
Merge branch 'master' into parameterised-transclusions
Jermolene 1ee77fb
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene dbea341
RealEstate demo: Set lat, long, price fields to be numeric
Jermolene 0d1667c
Merge branch 'master' into parameterised-transclusions
Jermolene be118af
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene dae48d4
Clean up Flickr demo
Jermolene c8b2146
Update geomap widget to refresh properly
Jermolene b80cf8c
Add Leaflet MasterCluster plugin
Jermolene 235b2f7
Setup the marker cluster plugin
Jermolene b1f8d3e
Rearrange real estate demo
Jermolene 800049e
Reduce default cluster radius
Jermolene f36e45f
Beginnings of real estate demo
Jermolene ea055f2
Merge branch 'master' into parameterised-transclusions
Jermolene 9700030
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 3be822f
Fix interpretation of HTTP status codes
Jermolene 6beb058
Real estate demo: Make columns hideable
Jermolene 85bbb08
Real estate demo: sortability
Jermolene a1a1f9c
Real estate demo: search and limit
Jermolene 44fb669
Fix typo
Jermolene f417bdb
Merge branch 'master' into parameterised-transclusions
Jermolene e051b2d
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 9ab2623
Fix lat long transposition
Jermolene 17ebeaf
Fix startup ordering
Jermolene bb5489b
Add geolookup operator
Jermolene b5d790a
Real Estate Demo: Add support for computed columns
Jermolene 5a9bb0e
Real estate demo: Increase result limit
Jermolene 2a2939f
Merge branch 'master' into parameterised-transclusions
Jermolene eab670a
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 449562e
Remove demo data
Jermolene 3699780
Track map pan and zoom state in a state tiddler
Jermolene f3d0de2
WIP
Jermolene 18b8b12
Use geojson extension for geojson file
Jermolene aa532a9
Use geojson extensions for another geojson file
Jermolene f9751f1
Merge branch 'master' into parameterised-transclusions
Jermolene 1dda5c8
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 1fbc35e
Split demo from the geospatial plugin into its own edition
Jermolene ff70949
Add build targets required by ./bin/site-build.sh...
Jermolene c002390
CI Fixes
Jermolene 57627b2
Fix default tab
Jermolene a96e3f4
Rearranging geospatial plugin vs. edition
Jermolene eba030a
More refactoring between demo and plugin
Jermolene cd46d9e
Start of plugin docs
Jermolene 0cdf99d
Display GeoJSON properties on click
Jermolene b5e9219
Fix layer lookup demo
Jermolene 3c0cae0
Restore XLSX Utils plugin and dependencies
Jermolene e2cc32a
Merge branch 'master' into parameterised-transclusions
Jermolene 8c98fc4
Merge branch 'master' into parameterised-transclusions
Jermolene b74646a
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 5940698
Cleanup docs
Jermolene cff3db6
Merge branch 'master' into parameterised-transclusions
Jermolene 7ba666b
Merge branch 'master' into parameterised-transclusions
Jermolene 3a42c86
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene a93eda0
Remove 5.2.8 release note
Jermolene bb2dea2
Remove 5.2.8 release note
Jermolene 9fdb81b
Docs update
Jermolene bd7742d
Fix minor refreshing bug for geomap widget
Jermolene ab845fe
Docs updates
Jermolene 28a33df
Add jsonset operator
Jermolene 2a19e20
Add geonearestpoint operator
Jermolene 3a411e9
jsonset: support for other data types and documentation
Jermolene 399089a
Add logo
Jermolene 2e92297
Add link to preview build
Jermolene a71150a
jsonset: add support for assigning JSON strings
Jermolene 5b271bb
Fix nonstandard initialisation code for fill/parameter/slot widgets
Jermolene a2cbb6f
Merge branch 'master' into parameterised-transclusions
Jermolene a4f0fc6
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 3689171
Merge branch 'master' into parameterised-transclusions
Jermolene 3bed84e
Merge branch 'master' into geospatial-plugin
Jermolene de9ea40
Introduce testcase widget so that we can reuse testcases as documenta…
Jermolene ae3ed08
Update logo
Jermolene ca75842
Testcasewidget: Add tabs for switching between source tiddlers
Jermolene da2d0be
Testcase appearance tweaks
Jermolene c405872
Switch to fluid-fixed layout
Jermolene 386b015
Docs for the testcase-transclude and testcase-view widgets
Jermolene c348924
Split docs into separate tabs
Jermolene 3c61e86
Extend testcase-view to be able to view other fields
Jermolene 68cb325
Extend default testcase template to show all fields of payload tiddlers
Jermolene e2223c4
Add some geomap examples
Jermolene 4427caa
Fix testcase rounded corners
Jermolene f41e712
Add a geomap layer demo
Jermolene b077208
Add favicon
Jermolene a5839ce
Switch from building the geospatial plugin as the main build back to …
Jermolene f41051b
Merge branch 'master' into parameterised-transclusions
Jermolene f6b3310
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 60714a4
Remove obsolete comment
Jermolene d9cfaf1
Remove geospatial plugin from tw5.com build
Jermolene a5d4f7a
Fix build link
Jermolene 3aac8e1
Add note about core enhancements included in this branch
Jermolene b6181e1
Refactor data widget implementation
Jermolene 6d617ce
Integrate test cases with the docs
Jermolene f2ccce2
Remove erroneously pasted docs material
Jermolene 6c9b811
Remove erroneously copied olc-encode tests within old-decode test case
Jermolene 683ec33
Refactor compound tiddler handling into data widget
Jermolene 1bc0662
Default test case template tweaks
Jermolene b91872b
Merge branch 'master' into parameterised-transclusions
Jermolene fca2552
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 62d0dd3
Move Flickr macros into geospatial plugin from the demo edition
Jermolene a974658
FlickrDemo: Simplify UI
Jermolene 59a8cf3
FlickrMacros: Use a template to define photo tiddler fields
Jermolene d057214
Remove geospatial plugin from prerelease default tiddlers
Jermolene 20e873a
Extend Flickr helpers to support photoTiddlerTemplate parameter
Jermolene 55e38eb
Update modification times of doc tiddlers
Jermolene 3b3879d
Update 5.3.0 release note
Jermolene 093274f
Remove custom CI step for this branch
Jermolene 8816efa
Restore standard sitetitle
Jermolene 0f61664
Merge branch 'parameterised-transclusions' into geospatial-plugin
Jermolene 57a365f
Merge branch 'master' into geospatial-plugin
Jermolene ed6cbab
Merge branch 'master' into geospatial-plugin
Jermolene e6b9bac
Flickr macro docs
Jermolene 546e55d
Rename $:/tags/GeoLayer to $:/tags/GeoFeature
Jermolene 539cc56
More test data (from leaflet.js)
Jermolene d527ae9
Captions should be transcluded, not viewed raw
Jermolene 88f4ad0
Make HTTP handler use wiki of widget that sent the message
Jermolene 2cf0423
Switch testcase widget to use an intrinsic template
Jermolene 60fbfa3
Complete Flickr demos
Jermolene 6a3977d
Extend geonearestpoint operator to work with feature collections
Jermolene 7f2d7ab
Extend realestate demo to show data on nearest volcano
Jermolene 1cb5716
Flickr macros: fix pagination after first page
Jermolene 5b8d281
Real estate demo: Fix nearest volcano
Jermolene 7b787fc
Merge branch 'master' into geospatial-plugin
Jermolene 0a2b0b3
Testcase docs update
Jermolene f700cd1
Testcase template: put title at the top and remove header row
Jermolene 19d2fe9
Docs correction
Jermolene b47c757
New geonearestpoint test case
Jermolene 4a0ffcf
Make test cases editable
Jermolene 9c12d16
Test case default template: Always put "Output" tab first
Jermolene 585c733
Initial Commit
Jermolene 0adc051
HttpClient object shouldn't need to know about events
Jermolene be1882d
Add support for cancelling HTTP requests
Jermolene fc22df9
Make the number of outstanding HTTP requests available in a state tid…
Jermolene f798bf5
Add a network activity button
Jermolene 499eafc
WIP
Jermolene b8b29aa
Merge branch 'tm-http-request-message' into geospatial-plugin
Jermolene 53715bd
Fix typo
Jermolene cdf0d63
Merge branch 'tm-http-request-message' into geospatial-plugin
Jermolene c6f15d8
Data widget: parse carriage returns in compound tiddlers
Jermolene cc7b857
Fix crash when cancelling more than one HTTP request
Jermolene 09e626e
Further fixes to cancelling outstanding HTTP requests
Jermolene d9b6384
Don't have data widget rendering its own JSON
Jermolene a927de5
Merge branch 'master' into tm-http-request-message
Jermolene cf71f6f
Merge branch 'tm-http-request-message' into geospatial-plugin
Jermolene 7fc0c0b
Fix missed docs update
Jermolene 29f4d34
Merge branch 'master' into geospatial-plugin
Jermolene 7f4f48d
Introduce geolayer widget for specifying layers for geomap
Jermolene ec2ec00
Fix breaking tests
Jermolene c10eeea
Remove docs references to obsolete widgets
Jermolene a14f038
Merge branch 'master' into geospatial-plugin
Jermolene 9bfe6e3
Tests for geounion, geointersect and geodifference
Jermolene dbabdfc
Support for multiple base layers
Jermolene 1f73d70
Merge branch 'master' into geospatial-plugin
Jermolene 7a82f15
Add a satellite base layer and another terrain base layer
Jermolene c7771c9
Add a note where to get more base layers
Jermolene 908ea64
Docs update
Jermolene cf44e0b
Merge branch 'master' into geospatial-plugin
Jermolene d785fa4
Geomap widget: fix default base layer rendering
Jermolene 463f0cd
Add startPosition and layersPanel attributes to geomap widget
Jermolene 3ee09af
Update geolayer widget docs with missing attributes
Jermolene 4b653c2
Add interactive demos for geounion, geodifference, geointersection
Jermolene e719d56
Open geofeature and geomarker maps on the bounds of their content
Jermolene ec7d248
Merge branch 'master' into tm-http-request-message
Jermolene 9285470
Merge branch 'master' into geospatial-plugin
Jermolene d9fa39a
Move settings from demo into plugin
Jermolene 33af598
Icon for geospatial plugin
Jermolene 483ade1
Fix missing body
Jermolene fb02f15
Merge branch 'master' into tm-http-request-message
Jermolene c474964
Merge branch 'master' into geospatial-plugin
Jermolene 8c9e669
Merge branch 'tm-http-request-message' into geospatial-plugin
Jermolene 5806741
Flickr Demo typo
Jermolene b2b51a3
Docs update
Jermolene c918f43
Add support for draggable markers
Jermolene 1a52286
Removed accidentally committed file
Jermolene 39daa29
Merge branch 'master' into geospatial-plugin
Jermolene 4b919e3
Remove unwanted log
Jermolene 5b4c024
Merge branch 'master' into geospatial-plugin
Jermolene 4494601
Merge branch 'master' into geospatial-plugin
Jermolene 9ab8f57
Add support for tm-request-geolocation message
Jermolene 65ac272
Fix typo
Jermolene fbcea2e
Fix bug when fitting to non-extistent bounds
Jermolene 1560221
Update main wiki greeting
Jermolene 87db53e
Merge branch 'master' into geospatial-plugin
Jermolene 05d3271
Use "Flickr helpers" instead of "Flickr macros"
Jermolene 38226cf
File renames for 05d32716037dd14b8a3741b28a82235defea4701
Jermolene a91a6f6
Fix testcase widget example
Jermolene 03b6413
Fix testcase widget refreshing
Jermolene 957cccd
Fix failing tests from 03b6413c7a519429ea75353faf32c0a0baf2b88e
Jermolene 4407cc8
Docs: Clarify that template must be in the payload
Jermolene 19c028a
Testcase widget: Exclude tab state tiddlers
Jermolene 10f09e0
Merge branch 'master' into geospatial-plugin
Jermolene e191217
Remove obsolete setquerystring operator
Jermolene 44736b6
Merge branch 'master' into geospatial-plugin
Jermolene 18c38dc
Remove obsolete change to --setfield command
Jermolene 45310bf
Fix tiddler name typo
Jermolene 497c56d
Initial Commit
Jermolene 86507ba
Add note to preview build
Jermolene 81f1994
Merge branch 'master' into testcase-widget
Jermolene 5eae32d
Fix whitespace and indenting
Jermolene a32d514
Fix crash with unset $tiddler attribute on <$data> widget
Jermolene 2c07310
Merge branch 'master' into testcase-widget
Jermolene 583ff88
Merge branch 'master' into geospatial-plugin
Jermolene 88f2bef
Merge branch 'master' into geospatial-plugin
Jermolene 056e7c2
Remove Stamen baselayers
Jermolene 7470832
Disable test that won't run in browser CI
Jermolene 4401081
Merge branch 'master' into testcase-widget
Jermolene e88895e
Disable broken tests
Jermolene 3d7c626
Merge branch 'master' into geospatial-plugin
Jermolene 786ab4d
Update olc-encode.tid (#7885)
Drevarr f70e047
Merge branch 'master' into geospatial-plugin
Jermolene f0d6779
Merge branch 'master' into testcase-widget
Jermolene 17e939f
Don't duplicate "description" field in test cases
Jermolene 22ad439
Use different background colours for nested testcase widgets
Jermolene 57e74a0
Extend the testcase widget to run tests
Jermolene 1be73ad
Add testcases to control panel
Jermolene fa9e643
Add a view template body template to render testcase tiddlers
Jermolene 4758b6a
Test edition should display testcases
Jermolene d361a1e
Whitespace fixes
Jermolene 39d4633
Make testcase tiddler tempalte link to itself
Jermolene 0891331
Styling tweaks
Jermolene 6b4bd47
Docs improvements
Jermolene e8a3ffd
Styling tweaks
Jermolene e378c6c
Run the new tw5.com testcases in the test edition
Jermolene 1d89c79
Update data widget to display its content in JSON
Jermolene ff03a1b
Add testcase convenience procedure
Jermolene 0db4c44
Clearer testcases for data widget, and docs tweaks
Jermolene 43fe5e9
Don't expect our intentionally failing test to pass
Jermolene 00ac550
Extend testcase default template so that the display format can be ch…
Jermolene d5b7bc7
DataWidget docs typo
Jermolene 842434a
Merge branch 'testcase-widget' into geospatial-plugin
Jermolene 5165fcd
Merge branch 'master' into geospatial-plugin
Jermolene 7a25718
Merge branch 'master' into geospatial-plugin
Jermolene 24f13ae
Mark Geospatial plugin as experimental
Jermolene f5bf377
Merge branch 'master' into geospatial-plugin
Jermolene e8782b7
Merge branch 'master' into geospatial-plugin
Jermolene 6dc31b1
Update to Leaflet v1.9.4
Jermolene a0e8f32
Remove unneeded template
Jermolene a0d296c
Don't hide the volcanoes of the world data set
Jermolene bd2e329
Merge branch 'master' into geospatial-plugin
Jermolene 9186fd5
Update Flickr demo docs
Jermolene fb1f076
Merge branch 'master' into geospatial-plugin
Jermolene 6e342f9
Fix subtle typo that was preventing popups from working correctly
Jermolene 2526b75
Go back to hiding the volcanoes of the world by default
Jermolene b0c5f1b
Merge branch 'master' into geospatial-plugin
Jermolene 754fb6e
Clarify docs for tm-request-location
Jermolene a723055
Merge branch 'master' into geospatial-plugin
Jermolene d70167e
Update modified testcase from master
Jermolene e64aaaa
Prepare for merging
Jermolene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /*\ | ||
| title: $:/core/modules/filters/url-ops.js | ||
| type: application/javascript | ||
| module-type: filteroperator | ||
|
|
||
| Filter operators for URL operations | ||
|
|
||
| \*/ | ||
| (function(){ | ||
|
|
||
| /*jslint node: true, browser: true */ | ||
| /*global $tw: false */ | ||
| "use strict"; | ||
|
|
||
| exports["setquerystring"] = function(source,operator,options) { | ||
| var name = operator.operands.length >= 1 ? operator.operands[0] : null, | ||
| value = operator.operands.length >= 2 ? operator.operands[1] : "", | ||
| results = []; | ||
| source(function(tiddler,title) { | ||
| results.push($tw.utils.setQueryStringParameter(title,name,value)); | ||
| }); | ||
| return results; | ||
| }; | ||
|
|
||
| })(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| /*\ | ||
| title: $:/core/modules/widgets/data.js | ||
| type: application/javascript | ||
| module-type: widget | ||
|
|
||
| Widget to represent a single item of data | ||
|
|
||
| \*/ | ||
| (function(){ | ||
|
|
||
| /*jslint node: true, browser: true */ | ||
| /*global $tw: false */ | ||
| "use strict"; | ||
|
|
||
| var Widget = require("$:/core/modules/widgets/widget.js").widget; | ||
|
|
||
| var DataWidget = function(parseTreeNode,options) { | ||
| this.dataWidgetTag = parseTreeNode.type; | ||
| this.initialise(parseTreeNode,options); | ||
| }; | ||
|
|
||
| /* | ||
| Inherit from the base widget class | ||
| */ | ||
| DataWidget.prototype = new Widget(); | ||
|
|
||
| /* | ||
| Render this widget into the DOM | ||
| */ | ||
| DataWidget.prototype.render = function(parent,nextSibling) { | ||
| this.parentDomNode = parent; | ||
| this.computeAttributes(); | ||
| this.execute(); | ||
| this.renderChildren(parent,nextSibling); | ||
| }; | ||
|
|
||
| /* | ||
| Compute the internal state of the widget | ||
| */ | ||
| DataWidget.prototype.execute = function() { | ||
| // Construct the child widgets | ||
| this.makeChildWidgets(); | ||
| }; | ||
|
|
||
| /* | ||
| Read the tiddler value(s) from a data widget – must be called after the .render() method | ||
| */ | ||
| DataWidget.prototype.readDataTiddlerValues = function() { | ||
| var self = this; | ||
| // Start with a blank object | ||
| var item = Object.create(null); | ||
| // Read any attributes not prefixed with $ | ||
| $tw.utils.each(this.attributes,function(value,name) { | ||
| if(name.charAt(0) !== "$") { | ||
| item[name] = value; | ||
| } | ||
| }); | ||
| item = new $tw.Tiddler(item); | ||
| // Deal with $tiddler, $filter or $compound-tiddler attributes | ||
| var tiddlers = [],title; | ||
| if(this.hasAttribute("$tiddler")) { | ||
| title = this.getAttribute("$tiddler"); | ||
| if(title) { | ||
| tiddlers.push(this.wiki.getTiddler(title)); | ||
| } | ||
| } | ||
| if(this.hasAttribute("$filter")) { | ||
| var filter = this.getAttribute("$filter"); | ||
| if(filter) { | ||
| var titles = this.wiki.filterTiddlers(filter); | ||
| $tw.utils.each(titles,function(title) { | ||
| var tiddler = self.wiki.getTiddler(title); | ||
| tiddlers.push(tiddler); | ||
| }); | ||
| } | ||
| } | ||
| if(this.hasAttribute("$compound-tiddler")) { | ||
| title = this.getAttribute("$compound-tiddler"); | ||
| if(title) { | ||
| tiddlers.push.apply(tiddlers,this.extractCompoundTiddler(title)); | ||
| } | ||
| } | ||
| // Convert the literal item to field strings | ||
| item = item.getFieldStrings(); | ||
| if(tiddlers.length === 0) { | ||
| if(Object.keys(item).length > 0 && !!item.title) { | ||
| return [item]; | ||
| } else { | ||
| return []; | ||
| } | ||
| } else { | ||
| var results = []; | ||
| $tw.utils.each(tiddlers,function(tiddler,index) { | ||
| var fields = tiddler.getFieldStrings(); | ||
| results.push($tw.utils.extend({},fields,item)); | ||
| }); | ||
| return results; | ||
| } | ||
| }; | ||
|
|
||
| /* | ||
| Helper to extract tiddlers from text/vnd.tiddlywiki-multiple tiddlers | ||
| */ | ||
| DataWidget.prototype.extractCompoundTiddler = function(title) { | ||
| var tiddler = this.wiki.getTiddler(title); | ||
| if(tiddler && tiddler.fields.type === "text/vnd.tiddlywiki-multiple") { | ||
| var text = tiddler.fields.text || "", | ||
| rawTiddlers = text.split(/\r?\n\+\r?\n/), | ||
| tiddlers = []; | ||
| $tw.utils.each(rawTiddlers,function(rawTiddler) { | ||
| var fields = Object.create(null), | ||
| split = rawTiddler.split(/\r?\n\r?\n/mg); | ||
| if(split.length >= 1) { | ||
| fields = $tw.utils.parseFields(split[0],fields); | ||
| } | ||
| if(split.length >= 2) { | ||
| fields.text = split.slice(1).join("\n\n"); | ||
| } | ||
| tiddlers.push(new $tw.Tiddler(fields)); | ||
| }); | ||
| return tiddlers; | ||
| } else { | ||
| return []; | ||
| } | ||
| }; | ||
|
|
||
| /* | ||
| Selectively refreshes the widget if needed. Returns true if the widget or any of its children needed re-rendering | ||
| */ | ||
| DataWidget.prototype.refresh = function(changedTiddlers) { | ||
| // Refresh our attributes | ||
| var changedAttributes = this.computeAttributes(); | ||
| // Refresh our children, and indicate that we refreshed if any of our attribute values have changed | ||
| return this.refreshChildren(changedTiddlers) || $tw.utils.count(changedAttributes) > 0; | ||
| }; | ||
|
|
||
| exports.data = DataWidget; | ||
|
|
||
| })(); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rawTiddlersare split with 2 or more NLs ...text.split("\n+\n")can
rawTiddlerbe split with 2 new-lines againrawTiddler.split(/\r?\n\r?\n/mg);... Did I misread something here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmario –
text.split("\n+\n")is not a regular expression, it's matching a plus sign surrounded by newlines. I think you're right that we should include support for carriage returns.