fix: pin http-network-relay to fd-leak fix commit#688
Open
fix: pin http-network-relay to fd-leak fix commit#688
Conversation
Pins to Thymis-io/http-network-relay#77 which fixes the fd leak in edge_agent read_from_tcp_and_send(). Revert the pin to main once that PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on Thymis-io/http-network-relay#77.
Pins
http-network-relayto the commit that fixes the fd leak inread_from_tcp_and_send()(see that PR for full root-cause analysis).After Thymis-io/http-network-relay#77 is merged, this PR should be updated to drop the commit pin and point back to
main(or a tagged release if one is cut).Related: #687 (
LimitNOFILE=infinitystopgap already merged to this repo)