Use new ID for live reporting period to ensure reset#66
Merged
martinjaeger merged 1 commit intomainfrom Dec 19, 2025
Merged
Conversation
The period was changed from seconds to milliseconds in b7b67f4. For devices which had their previous setting stored in flash or EEPROM, this led to publishing intervals of e.g. 1 ms instead of 1 s, which may completely block the MCU trying to publish the reports. By using a new ID, the previously stored value is ignored and the default value is used instead.
martinjaeger
added a commit
to LibreSolar/bms-firmware
that referenced
this pull request
Dec 19, 2025
The reason was that due to an update in the unit of the live reporting period the BMS would try to send out reports in 1 ms intervals if it had a reporting period from previous firmware versions stored in the flash. See also original ThingSet SDK PR: ThingSet/thingset-zephyr-sdk#66
Contributor
|
Sorry for the mess ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The period was changed from seconds to milliseconds in b7b67f4. For devices which had their previous setting stored in flash or EEPROM, this led to publishing intervals of e.g. 1 ms instead of 1 s, which may completely block the MCU trying to publish the reports.
By using a new ID, the previously stored value is ignored and the default value is used instead.
CC @jalinei