forked from dimforge/wgsparkl
-
Notifications
You must be signed in to change notification settings - Fork 0
Asset loader #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ThierryBerger
wants to merge
6
commits into
sample_color_model
Choose a base branch
from
asset_loader
base: sample_color_model
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Asset loader #1
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f37690a
add asset loader for 3d, working on web
ThierryBerger ed8154e
make 2d use new loader
ThierryBerger c6e0974
remove incorrect scenestate change + add afew comments + reduced subs…
ThierryBerger c59b3d5
ability to change example if loading is too long or failed
ThierryBerger 81da53b
fix warnings
ThierryBerger eef2bd3
show an error when asset loading failed
ThierryBerger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| use bevy::asset::LoadState; | ||
| use bevy::ecs::system::SystemId; | ||
| use bevy::prelude::*; | ||
| use bevy::render::renderer::RenderDevice; | ||
|
|
@@ -18,12 +19,13 @@ pub fn load_scene_plugin(app: &mut App) { | |
| #[derive(Resource, Default)] | ||
| pub struct CurrentSceneId(pub usize); | ||
|
|
||
| #[derive(Copy, Clone, States, Hash, PartialEq, Eq, Debug, Default)] | ||
| #[derive(Clone, States, Hash, PartialEq, Eq, Debug, Default)] | ||
| pub enum SceneState { | ||
| #[default] | ||
| Waiting, | ||
| Loading, | ||
| Loaded, | ||
| LoadingError(Vec<(String, String)>), | ||
| } | ||
|
|
||
| #[derive(Resource)] | ||
|
|
@@ -64,13 +66,32 @@ pub fn check_scene_loaded( | |
| loading_assets: Res<LoadingAssets>, | ||
| asset_server: Res<AssetServer>, | ||
| ) { | ||
| let errors = loading_assets | ||
| .assets | ||
| .iter() | ||
| .filter_map(|a| { | ||
| if let Some(load_state) = asset_server.get_load_state(a.1) { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unse |
||
| return match load_state { | ||
| LoadState::Failed(error) => Some((a.0.clone(), error.to_string())), | ||
| _ => None, | ||
| }; | ||
| } | ||
| None | ||
| }) | ||
| .collect::<Vec<_>>(); | ||
| if !errors.is_empty() { | ||
| next_scene_state.set(SceneState::LoadingError(errors)); | ||
| return; | ||
| } | ||
|
|
||
| if loading_assets | ||
| .assets | ||
| .iter() | ||
| .any(|a| !asset_server.is_loaded_with_dependencies(a.1)) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| next_scene_state.set(SceneState::Loaded); | ||
| } | ||
| pub fn call_init_state( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type error ?