Fixed Folia related bugs + /sethome w/o ServiceIO not working #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NonSwag
commented
May 18, 2025
NonSwag
commented
- Fixed /weather command for Folia
- Fixed /time add/set command for Folia
- Fixed /homes command for Folia
- Fixed /warps command for Folia
- Fixed /sethome without ServiceIO installed not doing anything for non-op players
Centralized `getMaxHomeCount` in `ServiceController` to improve reusability. Added error handling for `SetHomeCommand` to log failures.
Added exception handling in `setWarp` to log errors. Removed redundant exception handling from SetWarpCommand for cleaner code.
Replaced non-Folia compatible scheduler calls with Folia-compliant alternatives in `WarpsCommand` and `HomesCommand`.
Updated commands to use `GlobalRegionScheduler` for thread safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.