Fix support for parallel execution on CircleCI#336
Merged
TheKevJames merged 2 commits intoTheKevJames:masterfrom Nov 11, 2021
Merged
Fix support for parallel execution on CircleCI#336TheKevJames merged 2 commits intoTheKevJames:masterfrom
TheKevJames merged 2 commits intoTheKevJames:masterfrom
Conversation
TheKevJames
approved these changes
Nov 11, 2021
Owner
TheKevJames
left a comment
TheKevJames
left a comment
There was a problem hiding this comment.
Thank you for the contribution! LGTM
andy-maier
pushed a commit
to andy-maier/coveralls-python
that referenced
this pull request
Dec 23, 2022
Co-authored-by: Elijah Shaw-Rutschman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for parallel execution with CircleCI does not function as expected. With 16 parallel execution nodes followed by the parallel-complete webhook, the following result is seen on the Coveralls dashboard. Note the
.16at the end, indicating that only the final node's coverage report was processed correctly.This PR makes a minor change to utilize the
CIRCLE_NODE_INDEX, which is required for parallel execution support. This change mirrors the functionality from coveralls-ruby.Utilizing e26d574, subsequent runs yielded the expected results on the Coveralls dashboard.
