v 1.9 #39
Open
v 1.9 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: TheJoeFin <[email protected]>
Co-authored-by: TheJoeFin <[email protected]>
…r file access Co-authored-by: TheJoeFin <[email protected]>
Co-authored-by: TheJoeFin <[email protected]>
…SVG encoding Co-authored-by: TheJoeFin <[email protected]>
Enhanced logo overlay precision by aligning dimensions and padding to QR code module boundaries. Updated SVG logo embedding for consistency and accuracy. Increased allowable logo size for error correction levels. Added null checks for clipboard operations to improve robustness. Refactored code for better readability and maintainability.
Introduced `logoPaddingPixels` parameter to control padding or cropping around logos in QR codes. Updated `BarcodeHelpers`, `BarcodeImageItem`, and `MainViewModel` to support this feature. Enhanced SVG and bitmap generation logic, added a UI slider for dynamic padding adjustment, and improved code consistency and rendering quality.
Refactored QR code logo embedding logic to use "punchout size" for better clarity and flexibility. Simplified calculations for punchout area, logo dimensions, and padding. Updated SVG embedding to reduce file size and align with new logic. Revised `MainPage.xaml` labels and tooltips to reflect updated terminology and functionality.
Updated `OverlayLogoOnQrCode` and `EmbedLogoInSvg` methods to accept a `backgroundColor` parameter, enabling customization of the punchout background color in both bitmap and SVG formats. Adjusted related logic and comments to reflect this enhancement.
- Adjusted QR code margin for tighter generation. - Enhanced logo overlay logic with improved scaling and alignment. - Refined padding and logo size calculations for better accuracy. - Updated default logo settings for size and padding. - Simplified error correction level handling with fixed values. - Improved stream handling with explicit type usage. - Enhanced UI with `SplitButton` for logo options and sliders. - Consolidated bindings and improved code readability in XAML. - Standardized formatting and improved code consistency. - Fixed logo resizing issues and minor binding inconsistencies.
Co-authored-by: TheJoeFin <[email protected]>
Co-authored-by: TheJoeFin <[email protected]>
…pport Co-authored-by: TheJoeFin <[email protected]>
…olors and logos Co-authored-by: TheJoeFin <[email protected]>
Refine the logic for setting the SizeTextVisible property to also hide the size text when a logo image is present, in addition to the existing HideMinimumSizeText condition.
Reduced the `Spacing` property of the `StackPanel` named `QrCodeOptions` from `12` to `6` to optimize spacing. Decreased the `Width` of the "Code Color" and "Background Color" buttons from `68` to `48` to improve the visual design and save space in the user interface.
Add logo overlay to QR code center with adjustable size, file-based history persistence, and cross-page state preservation
The namespace declaration in `FaqItem.cs` was updated to remove an extraneous invisible character, ensuring proper formatting. Added two new FAQ items to the `FaqItem` class: 1. "How does adding an image affect the QR Code?" - Explains the impact of adding a logo to the center of a QR Code and the importance of error correction levels. 2. "How is the center image stored in SVG files?" - Describes how center images are embedded in SVG files using Base64 encoding and notes that the image is stored as a raster (PNG).
TheJoeFin
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding images to the center of QR Codes!