feat: user-selectable mood face in notch #798
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Adds a dynamic notch face with user-selectable moods. ### Changes - New SwiftUI view `NotchMoodView` that renders eyes/mouth/eyebrows parametrically. - Enum `Mood` + `MoodParams` with presets (happy, neutral, sad, angry, sleepy, love, bored, surprised). - Idle animations: blink + subtle breathing. - Persistence via @AppStorage("selectedMood"). - Settings/Context menu entry to switch moods. ### Testing - Built & tested on macOS 14/15. - Verified notch rendering, menu changes, persistence across relaunch. - CPU idle ≤ 2% during animation. ### Notes - Pure SwiftUI, no new dependencies. - Backwards compatible; defaults to `happy`.
Author
|
Author
|
@Alexander5015 |
Author
|
@Alexander5015 |
Member
|
I haven't had a chance to review it yet. When I do, I will leave some feedback in a review |
Member
Alexander5015
left a comment
Alexander5015
left a comment
There was a problem hiding this comment.
Please resolve the conflicts, and use UserDefaults for persistence. I know we currently have a mix, but most of it is handled in Constants.swift using this library. Once that is done, I can merge the changes.
Author
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dynamic notch face with user-selectable moods.
Changes
NotchMoodViewthat renders eyes/mouth/eyebrows parametrically.Mood+MoodParamswith presets (happy, neutral, sad, surprised).Testing
Notes
happy.