Skip to content

Conversation

@omeriadon
Copy link

This PR introduces a new “Notes” tab with the following features:

  • Toggle monospace font per note.
  • Search bar to filter notes.
  • Multiple notes sorted by most recently edited.
  • Stored in Application Support.

I also made some adjustements to Settings to make it macOS 26 compatible, but it is still backwards compatible with macOS 15 and earlier.

SCR-20250901-rwii-2

@omeriadon omeriadon changed the base branch from main to dev September 1, 2025 13:11
@omeriadon
Copy link
Author

Resolves #695

@Alexander5015
Copy link
Member

Thanks for the PR! Could you isolate your commits to just the changes for this PR so it doesn't include commits from main?

@omeriadon
Copy link
Author

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have accidentally removed localization for several strings as they are now marked as "extractionState" : "stale"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I reverted it to what the repo currently has it still had some errors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now when I view the localization file, I don't see any of the translations that are currently on dev. Also keep in mind that the string extraction is automatically done by Xcode, so the issue with strings being stale is probably in Settings and not the localization itself.

It also includes adding environment object so that view doesn't reinitialise and clear notes
There are still "stale errors" but it matches the repo so I didn't fix
When you change to notes tab, it focuses texteditor
When you change to other tab, focus is back to desktop app
@omeriadon
Copy link
Author

omeriadon commented Sep 2, 2025

I think I finished all the issues you pointed out, if theres there's anything else like optionally showing that tab please tell me!
Or a button in the bottom right to keep boringNotch open even if the cursor leaves the area

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now when I view the localization file, I don't see any of the translations that are currently on dev. Also keep in mind that the string extraction is automatically done by Xcode, so the issue with strings being stale is probably in Settings and not the localization itself.

@omeriadon
Copy link
Author

I have no idea why the toolbar item has centered itself, other than that the pre-macOS 15 window is good

But the macOS 26 one is broken, I do not know why since it's a very standard NavigationSplitView and Settings { }

SCR-20250903-scis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants