-
-
Notifications
You must be signed in to change notification settings - Fork 385
Add Notes Tab #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add Notes Tab #732
Conversation
|
Resolves #695 |
|
Thanks for the PR! Could you isolate your commits to just the changes for this PR so it doesn't include commits from main? |
And updated SettingsView for macOS 26
0949779 to
97749c6
Compare
|
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have accidentally removed localization for several strings as they are now marked as "extractionState" : "stale"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I reverted it to what the repo currently has it still had some errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now when I view the localization file, I don't see any of the translations that are currently on dev. Also keep in mind that the string extraction is automatically done by Xcode, so the issue with strings being stale is probably in Settings and not the localization itself.
It also includes adding environment object so that view doesn't reinitialise and clear notes
There are still "stale errors" but it matches the repo so I didn't fix
When you change to notes tab, it focuses texteditor When you change to other tab, focus is back to desktop app
|
I think I finished all the issues you pointed out, if theres there's anything else like optionally showing that tab please tell me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now when I view the localization file, I don't see any of the translations that are currently on dev. Also keep in mind that the string extraction is automatically done by Xcode, so the issue with strings being stale is probably in Settings and not the localization itself.

This PR introduces a new “Notes” tab with the following features:
I also made some adjustements to Settings to make it macOS 26 compatible, but it is still backwards compatible with macOS 15 and earlier.