refactor: restructure packages to improve extensibility #919
Conversation
fgreinacher
force-pushed
the
refactor/packaging
branch
2 times, most recently
from
87b7fce to
4639cf8
Compare
fgreinacher
force-pushed
the
refactor/packaging
branch
from
4639cf8 to
69928d1
Compare
|
@vbreuss Could you have a quick look at this? |
...tractions.TestingHelpers.Tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests.csproj
Outdated
Show resolved
Hide resolved
@fgreinacher : I finished my review :-) |
fgreinacher
force-pushed
the
refactor/packaging
branch
from
ac854ef to
3d47f3b
Compare
...tractions.TestingHelpers.Tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests.csproj
Show resolved
Hide resolved
This change splits the System.IO.Abstractions package into TestableIO.System.IO.Abstractions and TestableIO.System.IO.Abstractions.Wrappers. The former contains just the interfaces and the latter the default wrapper implementations. The package System.IO.Abstractions still exists as meta package to reduce impact on existing users. The same applies to TestableIO.System.IO.Abstractions.TestingHelpers. BREAKING CHANGE: This refactoring moves all types to the TestableIO.System.IO.Abstractions library. Users might need to recompile their libraries. Co-authored-by: Valentin Breuß <[email protected]>
fgreinacher
force-pushed
the
refactor/packaging
branch
from
3d47f3b to
2f0122d
Compare
|
Thanks for your comments @vbreuss, ready for round 2️⃣ |
vbreuss
left a comment
vbreuss
left a comment
There was a problem hiding this comment.
@fgreinacher : Looks good!
What is the Benchmarks project?
Should it also have the "TestableIO" prefix?
It seems I can't resolve conversations or did I just not find the corresponding button?
|
Thanks for the quick review @vbreuss!
It contains some performance benchmarks. I will also add the prefix there!
I guess that's because you're not member of the organization. If you're interested helping out here, just say so and I'll add you as collaborator. |
@fgreinacher : I would be happy to help out! |
Cool thanks, I added you to the project! |
This change splits the System.IO.Abstractions package into TestableIO.System.IO.Abstractions and TestableIO.System.IO.Abstractions.Wrappers. The former contains just the interfaces and the latter the default wrapper implementations. The package System.IO.Abstractions still exists as meta package to reduce impact on existing users. The same applies to TestableIO.System.IO.Abstractions.TestingHelpers.
BREAKING CHANGE: This refactoring moves all types to the TestableIO.System.IO.Abstractions library. Users might need to recompile their libraries.