Skip to content

feat: adjust timestamps when accessing and modifying files #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgreinacher merged 3 commits into from
Jul 4, 2022
Merged

feat: adjust timestamps when accessing and modifying files #861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
327f4a7
Add adjusted timestamps on copied MockFiles
xtopaz Jun 29, 2022
920527b
Fix timestamps in MockFileStream
xtopaz Jul 2, 2022
d5f5d1e
Fix timestamp update when file is opened
xtopaz Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/System.IO.Abstractions.TestingHelpers/MockFileStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class MockFileStream : MemoryStream
private readonly string path;
private readonly FileAccess access = FileAccess.ReadWrite;
private readonly FileOptions options;

private readonly MockFileData fileData;
private bool disposed;

/// <inheritdoc />
Expand All @@ -31,7 +31,8 @@ public MockFileStream(
throw CommonExceptions.FileAlreadyExists(path);
}

var fileData = mockFileDataAccessor.GetFile(path);
fileData = mockFileDataAccessor.GetFile(path);
fileData.LastAccessTime = DateTime.Now;
fileData.CheckFileAccess(path, access);

var existingContents = fileData.Contents;
Expand All @@ -40,8 +41,8 @@ public MockFileStream(
mode != FileMode.Truncate && mode != FileMode.Create;
if (keepExistingContents)
{
Write(existingContents, 0, existingContents.Length);
Seek(0, mode == FileMode.Append
base.Write(existingContents, 0, existingContents.Length);
base.Seek(0, mode == FileMode.Append
? SeekOrigin.End
: SeekOrigin.Begin);
}
Expand All @@ -59,7 +60,9 @@ public MockFileStream(
throw CommonExceptions.FileNotFound(path);
}

mockFileDataAccessor.AddFile(path, new MockFileData(new byte[] { }));
fileData = new MockFileData(new byte[] { });
fileData.CreationTime = fileData.LastWriteTime = fileData.LastAccessTime = DateTime.Now;
mockFileDataAccessor.AddFile(path, fileData);
}

this.access = access;
Expand All @@ -71,6 +74,20 @@ public MockFileStream(
/// <inheritdoc />
public override bool CanWrite => access.HasFlag(FileAccess.Write);

/// <inheritdoc />
public override int Read(byte[] buffer, int offset, int count)
{
fileData.LastAccessTime = DateTime.Now;
return base.Read(buffer, offset, count);
}

/// <inheritdoc />
public override void Write(byte[] buffer, int offset, int count)
{
fileData.LastWriteTime = fileData.LastAccessTime = DateTime.Now;
base.Write(buffer, offset, count);
}

/// <inheritdoc />
protected override void Dispose(bool disposing)
{
Expand Down
100 changes: 98 additions & 2 deletions tests/System.IO.Abstractions.TestingHelpers.Tests/MockFileOpenTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using System.Threading.Tasks;

namespace System.IO.Abstractions.TestingHelpers.Tests
{
using Collections.Generic;
Expand Down Expand Up @@ -217,7 +219,7 @@ public void MockFile_OpenText_ShouldRetainLastWriteTime()
}

[Test]
public void MockFile_OpenText_ShouldRetainLastAccessTime()
public void MockFile_OpenText_ShouldUpdateLastAccessTime()
{
// Arrange
var fs = new MockFileSystem();
Expand All @@ -234,7 +236,101 @@ public void MockFile_OpenText_ShouldRetainLastAccessTime()
}

// Assert
Assert.AreEqual(lastAccessTime, fs.FileInfo.FromFileName(filepath).LastAccessTime);
Assert.LessOrEqual(DateTime.Now - fs.FileInfo.FromFileName(filepath).LastAccessTime, TimeSpan.FromSeconds(1));
}

[Test]
public void MockFile_Read_ShouldRetainCreationTimeAndUpdateLastAccessTime()
{
// Arrange
var fs = new MockFileSystem();
var filepath = XFS.Path(@"C:\TestData\test.txt");
var file = new MockFileData(new byte[] { 1, 2, 3 });
var lastAccessTime = new DateTime(2012, 03, 21);
file.LastAccessTime = lastAccessTime;
var creationTime = new DateTime(2012, 03, 20);
file.CreationTime = creationTime;
fs.AddFile(filepath, file);

var fi = fs.FileInfo.FromFileName(filepath);
var stream = fi.OpenRead();
var buffer = new byte[16];
stream.Read(buffer, 0, buffer.Length);
fi.Refresh();
// Assert
Assert.AreEqual(creationTime, fi.CreationTime);
Assert.LessOrEqual(DateTime.Now - fi.LastAccessTime, TimeSpan.FromSeconds(1));
}

[Test]
public async Task MockFile_ReadAsync_ShouldRetainCreationTimeAndUpdateLastAccessTime()
{
// Arrange
var fs = new MockFileSystem();
var filepath = XFS.Path(@"C:\TestData\test.txt");
var file = new MockFileData(new byte[] { 1, 2, 3 });
var lastAccessTime = new DateTime(2012, 03, 21);
file.LastAccessTime = lastAccessTime;
var creationTime = new DateTime(2012, 03, 20);
file.CreationTime = creationTime;
fs.AddFile(filepath, file);

var fi = fs.FileInfo.FromFileName(filepath);
var stream = fi.OpenRead();
var buffer = new byte[16];
await stream.ReadAsync(buffer, 0, buffer.Length);
fi.Refresh();
// Assert
Assert.AreEqual(creationTime, fi.CreationTime);
Assert.LessOrEqual(DateTime.Now - fi.LastAccessTime, TimeSpan.FromSeconds(1));
}

[Test]
public void MockFile_Write_ShouldRetainCreationTimeAndUpdateLastAccessTimeAndLastWriteTime()
{
// Arrange
var fs = new MockFileSystem();
var filepath = XFS.Path(@"C:\TestData\test.txt");
var file = new MockFileData(new byte[] { 1, 2, 3 });
var lastAccessTime = new DateTime(2012, 03, 21);
file.LastAccessTime = lastAccessTime;
var creationTime = new DateTime(2012, 03, 20);
file.CreationTime = creationTime;
fs.AddFile(filepath, file);

var fi = fs.FileInfo.FromFileName(filepath);
var stream = fi.OpenWrite();
var buffer = new byte[16];
stream.Write(buffer, 0, buffer.Length);
fi.Refresh();
// Assert
Assert.AreEqual(creationTime, fi.CreationTime);
Assert.LessOrEqual(DateTime.Now - fi.LastAccessTime, TimeSpan.FromSeconds(1));
Assert.LessOrEqual(DateTime.Now - fi.LastWriteTime, TimeSpan.FromSeconds(1));
}

[Test]
public async Task MockFile_WriteAsync_ShouldRetainCreationTimeAndUpdateLastAccessTimeAndLastWriteTime()
{
// Arrange
var fs = new MockFileSystem();
var filepath = XFS.Path(@"C:\TestData\test.txt");
var file = new MockFileData(new byte[] { 1, 2, 3 });
var lastAccessTime = new DateTime(2012, 03, 21);
file.LastAccessTime = lastAccessTime;
var creationTime = new DateTime(2012, 03, 20);
file.CreationTime = creationTime;
fs.AddFile(filepath, file);

var fi = fs.FileInfo.FromFileName(filepath);
var stream = fi.OpenWrite();
var buffer = new byte[16];
await stream.WriteAsync(buffer, 0, buffer.Length);
fi.Refresh();
// Assert
Assert.AreEqual(creationTime, fi.CreationTime);
Assert.LessOrEqual(DateTime.Now - fi.LastAccessTime, TimeSpan.FromSeconds(1));
Assert.LessOrEqual(DateTime.Now - fi.LastWriteTime, TimeSpan.FromSeconds(1));
}

[Test]
Expand Down