Skip to content

fix: make MockFile.Exists handle empty string #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgreinacher merged 4 commits into from
Feb 17, 2022
Merged

fix: make MockFile.Exists handle empty string #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
207202e
fix: make MockFile.Exists handle empty string
mas-dude Feb 10, 2022
9d2ec6f
Added try catch block to exists to be inline with dotnet runtime
mas-dude Feb 15, 2022
e88a38c
Added NotSupportedException to catch block
mas-dude Feb 16, 2022
6e1a281
Added comments for unhandled exception
mas-dude Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/System.IO.Abstractions.TestingHelpers/MockFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,25 @@ public override bool Exists(string path)
return false;
}

var file = mockFileDataAccessor.GetFile(path);
return file != null && !file.IsDirectory;
if (path.Trim() == string.Empty)
{
return false;
}

//Not handling exceptions here so that mock behaviour is as similar as possible to System.IO.File.Exists (See #810)
try
{
mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, nameof(path));

var file = mockFileDataAccessor.GetFile(path);
return file != null && !file.IsDirectory;
}
catch (ArgumentException) { }
catch (NotSupportedException) { }
catch (IOException) { }
catch (UnauthorizedAccessException) { }

return false;
}

/// <inheritdoc />
Expand Down
26 changes: 26 additions & 0 deletions tests/System.IO.Abstractions.TestingHelpers.Tests/MockFileExistsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,32 @@ public void MockFile_Exists_ShouldReturnFalseForNullPath()
Assert.IsFalse(result);
}

[Test]
public void MockFile_Exists_ShouldReturnFalseForEmptyStringPath()
{
// Arrange
var fileSystem = new MockFileSystem();

// Act
var result = fileSystem.File.Exists(string.Empty);

// Assert
Assert.IsFalse(result);
}

[Test]
public void MockFile_Exists_ShouldReturnFalseForInvalidCharactersInPath()
{
// Arrange
var fileSystem = new MockFileSystem();

// Act
var result = fileSystem.File.Exists(@"C:""*/:<>?|abc");

// Assert
Assert.IsFalse(result);
}

[Test]
public void MockFile_Exists_ShouldReturnFalseForDirectories()
{
Expand Down