Skip to content

Make things extensibile #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SonOfSardaar wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Make things extensibile #292

SonOfSardaar wants to merge 37 commits into from

Conversation

@SonOfSardaar
Copy link
Contributor

@SonOfSardaar SonOfSardaar commented Oct 29, 2025 •
edited
Loading

some random refactoring
added IStepTitleFactory and IFluentScannerFactory to make things bit more extensible
clean up appveyor related files
added few more tests towards code coverage

Gurpreet Singh added 21 commits October 29, 2025 20:13
clean up appveyor related files
a026935 
some random refactoring
added IStepTitleFactory and IFluentScannerFactory
add step title factory tests
d07d2bd
add step title factory tests
fbfeaa5
run tests fighting for configurator in same collection
3d1a0b4
cleanup ExceptionProcessor
32fd607
remove un used property function
e3e1409
cleanup
4e471e3
remove unused code. these attributes are defined in this assembly but…
4d7de81 
… are not used or handled by any code.
remove missing doc reference
4e379ec
use beta tag for packages built from a branch
dfd7e55
fix the action script
21df381
try update gitversion to use beta for non default branches
03c6ea3
fix GitVersion.yml
fec903e
fixed gitversion
fe622a4
Merge branch 'main' of github.com:TestStack/TestStack.BDDfy into feat…
352bb26 
…ure/extensibility
add MeansImplicitUseAttribute back in code
b547846
clean up
1153dd0
revert to keep all Annotations.cs
0f56380
additional coverage
39b701f
improving code coverage
71cde21
publish manual or default branch
ce88266
Gurpreet Singh added 4 commits November 3, 2025 18:33
additional code coverage
ee49527
fix typo in dotnet test command
eb2873a
remove run settings
9e7e1e4
disable diff runner on CI pipeline
0ae45ff 
added script to generate detailed coverage for local analysis. these are not meant to run on CI pipeline (that uses different summary)
@SonOfSardaar SonOfSardaar mentioned this pull request Nov 4, 2025
Closed
@leandro-hawktech
Copy link

leandro-hawktech commented Dec 11, 2025

Hi @SonOfSardaar, I went through the files and had a look at all of them, most were small changes and they look good. Are you looking for any specific feedback in this PR? Otherwise, I made a couple of comments on small things I found.

Thanks for the updates you made!

@SonOfSardaar
Copy link
Contributor Author

SonOfSardaar commented Dec 11, 2025

Hi @SonOfSardaar, I went through the files and had a look at all of them, most were small changes and they look good. Are you looking for any specific feedback in this PR? Otherwise, I made a couple of comments on small things I found.

Thanks for the updates you made!

Thanks @leandro-hawktech . I was waiting to see if I could get a second pair of eyes on these changes. I did not want to rush merging without good review. I also have a beta nuget published hoping i would get some comments or feedback if there were any issues.

@SonOfSardaar SonOfSardaar requested a review from MehdiK as a code owner December 11, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MehdiK MehdiK Awaiting requested review from MehdiK MehdiK is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SonOfSardaar @leandro-hawktech