Skip to content

Update AbstractSQLConfig.java #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2023
Merged

Update AbstractSQLConfig.java #603

merged 3 commits into from
Sep 24, 2023

Conversation

@cloudAndMonkey
Copy link
Contributor

@cloudAndMonkey cloudAndMonkey commented Aug 25, 2023

#602
假删除判断 bug

@TommyLemon
Copy link
Collaborator

TommyLemon commented Aug 25, 2023

boolean containNotDeletedValue 确实必须要把后面的 null 改为 false，否则执行赋值报错；
后面的 notDeletedValue 是作为条件 deletedKey = notDeletedValue 或 deletedKey != notDeletedValue 的值，应该不改。
可以具体调试下看看
image

@cloudAndMonkey
Copy link
Contributor Author

cloudAndMonkey commented Aug 29, 2023

@TommyLemon
最近有点忙, 星期六或星期天我来看看

@TommyLemon
Copy link
Collaborator

TommyLemon commented Aug 31, 2023

@TommyLemon 最近有点忙, 星期六或星期天我来看看

理解，可以的~

@TommyLemon TommyLemon merged commit 44fb269 into Tencent:master Sep 24, 2023
@TommyLemon TommyLemon mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TommyLemon TommyLemon TommyLemon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cloudAndMonkey @TommyLemon