Add support for localized billing accounts #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NitriKx
reviewed
Aug 1, 2017
Member
There was a problem hiding this comment.
Thanks for contributing! Billing files patterns should use "non-capturing" groups instead, and then avoid modifications on "matcher.group" calls. (http://www.rexegg.com/regex-disambiguation.html#noncap)
For instance:
Pattern.compile(".+-aws-billing-detailed-line-items-with-resources-and-tags-(?:[A-Z]+-)?(\\d\\d\\d\\d-\\d\\d).csv.zip");
vishesh92
force-pushed
the
support-localized-billing-accounts
branch
from
25e9374 to
d5d1cc3
Compare
Contributor
Author
|
@NitriKx Didn't know about that. Have updated the PR. |
NitriKx
added a commit
that referenced
this pull request
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your account is billed locally by AWS, e.g. by AISPL if you are in India, then the files generated for billing have AISPL in them
239874210271-aws-billing-detailed-line-items-with-resources-and-tags-AISPL-2017-01.csv.zipThis PR adds support for these types of reports.