Fix clippy::needless_continue lint in code generated by FromDeriveInput#429
Open
sbernauer wants to merge 1 commit intoTedDriggs:masterfrom
Open
Fix clippy::needless_continue lint in code generated by FromDeriveInput#429sbernauer wants to merge 1 commit intoTedDriggs:masterfrom
clippy::needless_continue lint in code generated by FromDeriveInput#429sbernauer wants to merge 1 commit intoTedDriggs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
FromDeriveInputderive macro, indarling/core/src/codegen/attrs_field.rs
Lines 90 to 93 in 7f7dee7
After enabling the needless_continue lint (as part of pedantic lints) in our codebase, it complained about the match statement generated by
darling. It suggests to "drop the continue expression".I was able to quickly fix the lint, however I'm not sure if the
continueis intentional preferred over{}. In which case I'm also happy to change this PR to add a#[expect(clippy::needless_continue)]to the generated code, just let me know!