Skip to content

[Feat] #16 - 마이페이지 뷰 UI 구현#17

Merged
L-j-h-c merged 7 commits intoTeamRecorDream:developfrom
L-j-h-c:feature/#16-SettingViewDesign
Oct 12, 2022
Merged

[Feat] #16 - 마이페이지 뷰 UI 구현#17
L-j-h-c merged 7 commits intoTeamRecorDream:developfrom
L-j-h-c:feature/#16-SettingViewDesign

Conversation

@L-j-h-c
Copy link
Copy Markdown
Contributor

@L-j-h-c L-j-h-c commented Oct 9, 2022

👻 작업한 내용

마이페이지 뷰 UI 구현

🎤 PR Point

  1. 기능을 제외한 UI 부분만 구현했습니다.
  2. UI Switch는 subView에 접근해서 강제로 크기를 조절했습니다.

📸 스크린샷

구현 내용 스크린샷
마이페이지 Simulator Screen Shot - iPhone 14 Pro - 2022-10-09 at 17 18 22

📮 관련 이슈

@L-j-h-c L-j-h-c added 록시보이 🌽 담당자 feat 구현·개선 사항에 관련된 내용입니다. labels Oct 9, 2022
@L-j-h-c L-j-h-c self-assigned this Oct 9, 2022
EunHee-Jeong
EunHee-Jeong previously approved these changes Oct 10, 2022
Copy link
Copy Markdown
Member

@EunHee-Jeong EunHee-Jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어용가리

Comment on lines +33 to +37
// deselected
self.subviews[0].subviews[0].layer.cornerRadius = cornerRadius
// selected
self.subviews[0].subviews[1].layer.cornerRadius = cornerRadius
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 살짝 고민을 하셨던 것 같은데...!

self.center = CGFloat(x: width / 2.adjustedWidth, y: height / 2.adjustedHeight) 이런 식으로 계산해도 좋을 것 같다는 생각이...

p.s.) adjusted~는 익스텐션이에요!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EunHee-Jeong
아하.. 일단 스냅킷으로 강제로 width height를 잡으면 레이아웃이 망가져서 trans를 쓴건데
혹시 써주신 코드의 기능이 어떤걸까요?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch 커스텀할 때(깎을때) 기준 좌표를 잡아서 하는 방식이 떠올라서요!! 저는 trans를 처음 봐서 ㅋㅋ 참고만 해주세요 ㅎㅅㅎ

Comment on lines +132 to +137
extension Reactive where Base: MyPageInteractionView {
public var isInteractionEnabled: Binder<Bool> {
return Binder(base) { view, isEnabled in
view.updateEnabledStatus(isEnabled)
}
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 또 뭐시여... 공부할 게 산더미

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EunHee-Jeong
.bind(interactionView.rx.isInteractionEnabled)와 같은 형식으로 데이터를 바로 바인딩할 수 있도록 해준 것입니다!

Suyeon9911
Suyeon9911 previously approved these changes Oct 11, 2022
Copy link
Copy Markdown
Member

@Suyeon9911 Suyeon9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 !!

Comment on lines +16 to +24

public class MyPageInteractionView: UIView {

// MARK: - Properties

public enum InteractionType {
case pushOnOff
case timeSetting
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 뷰 단위는 전부 DSKit의 Components로 따로 빼는건가유?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suyeon9911 넵 일단 저는 그렇게 구현해놨는데 편하신대로 Presentation에 넣어도 될것 같슴당~~!

Comment on lines +26 to +28
private let naviBar = RDNaviBar()
.rightButtonImage(RDDSKitAsset.Images.icnBack.image)
.title("마이페이지")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 네비바는 어디서 관리해주고 있나용? 어디 들어있는 친구여요?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSKit에 RDNaviBar에 있어요! 내비바는 다른 뷰에서 필요할 수도 있을 것 같아서 확장 가능하게 구현해뒀습니다

…m-iOS into feature/TeamRecorDream#16-SettingViewDesign

# Conflicts:
#	RecorDream-iOS/Projects/Modules/RD-DSKit/Derived/Sources/TuistAssets+RDDSKit.swift
@L-j-h-c L-j-h-c dismissed stale reviews from Suyeon9911 and EunHee-Jeong via dd4726e October 12, 2022 10:07
@L-j-h-c L-j-h-c merged commit bd61e84 into TeamRecorDream:develop Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat 구현·개선 사항에 관련된 내용입니다. 록시보이 🌽 담당자

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] 설정 뷰 UI 구현

3 participants