[Feat] 녹음 관련 QA - 무음모드, 재생 중지 + etc) 검색어 볼드 처리#144
Merged
Suyeon9911 merged 5 commits intodevelopfrom Feb 5, 2023
Merged
Conversation
EunHee-Jeong
previously approved these changes
Feb 5, 2023
Comment on lines
+190
to
+193
| if isPauseAudio { | ||
| owner.setPlayStatus(false) | ||
| owner.audioPlayer.pause() | ||
| } |
Suyeon9911
changed the title
Suyeon9911
changed the title
Member
Author
|
@EunHee-Jeong @L-j-h-c 검색어 볼드처리해주는 부분도 이 브랜치에서 작업해서 방금 추가했으니 확인 부탁드려용 ~
|
EunHee-Jeong
previously approved these changes
Feb 5, 2023
L-j-h-c
approved these changes
Feb 5, 2023
Contributor
L-j-h-c
left a comment
L-j-h-c
left a comment
There was a problem hiding this comment.
수고하셨습니다! AudioSession 관련 유용한 정보 감사합니다
Comment on lines
+199
to
+206
| private func setAudioSession() { | ||
| let audioSession = AVAudioSession.sharedInstance() | ||
| do { | ||
| try audioSession.setCategory(AVAudioSession.Category.playback, mode: .default) | ||
| } catch { | ||
| print("audioSession error: \(error.localizedDescription)") | ||
| } | ||
| } |
Comment on lines
+187
to
+193
| isPauseAudio | ||
| .withUnretained(self) | ||
| .subscribe(onNext: { (owner, isPauseAudio) in | ||
| if isPauseAudio { | ||
| owner.setPlayStatus(false) | ||
| owner.audioPlayer.pause() | ||
| } |
Contributor
There was a problem hiding this comment.
현재 사용되는 곳을 보니 Bool타입 중에서 true만 사용하고 있고, public method를 통해서 처리할 수 있을 것 같은데, 메모리 효율을 위해 method를 사용하는 방식으로 사용하는 것은 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
🎤 PR Point
📸 스크린샷
📮 관련 이슈