[Fix] #129 - 2차 QA 반영#130
Merged
EunHee-Jeong merged 9 commits intoTeamRecorDream:developfrom Jan 26, 2023
Merged
Conversation
L-j-h-c
previously approved these changes
Jan 24, 2023
Comment on lines
42
to
+49
| self.addSubview(lineView) | ||
| self.backgroundColor = RDDSKitAsset.Colors.white04.color | ||
| self.backgroundColor = RDDSKitAsset.Colors.dark.color | ||
| self.borderColor = .clear | ||
| self.selectedSegmentIndex = 0 | ||
| self.setImage(RDDSKitAsset.Images.icnGalleryOn.image, forSegmentAt: 0) | ||
| self.setImage(RDDSKitAsset.Images.icnListOn.image, forSegmentAt: 1) | ||
| self.selectedSegmentTintColor = RDDSKitAsset.Colors.white04.color | ||
| self.tintColor = RDDSKitAsset.Colors.white04.color | ||
| self.selectedSegmentTintColor = RDDSKitAsset.Colors.dark.color | ||
| self.tintColor = RDDSKitAsset.Colors.dark.color |
Contributor
There was a problem hiding this comment.
혹시 요부분 완성된 이미지도 공유해주시면 감사하겠습니다 ㅎㅎ
Contributor
There was a problem hiding this comment.
풀받아서 확인해보니 색이 바뀌어서 애니메이션이 보이지 않는데, 디자인과 협의하고 반영하는 것이 편하지 않을까요?
Member
Author
There was a problem hiding this comment.
변경 요청이 들어와서 논의 후에 변경하였습니다!
Comment on lines
+117
to
+128
| private func addTapGestureForCollectionView() { | ||
| let tap = UITapGestureRecognizer(target: self, action: #selector(didTapOutsideCollectionView)) | ||
| tap.numberOfTapsRequired = 2 | ||
| self.dreamSearchCollectionView.addGestureRecognizer(tap) | ||
| } | ||
| @objc | ||
| private func didTapOutsideCollectionView(_ recognizer: UITapGestureRecognizer) { | ||
| let tapLocation = recognizer.location(in: self.view) | ||
| if dreamSearchCollectionView.indexPathForItem(at: tapLocation) == nil { | ||
| self.view.endEditing(true) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
제스쳐 활용을 이런식으로 할 수도 있네요..! 배워갑니다~~
PR에 남겨주신 부분 보고 고민해 보았는데, 아이템이 있냐 없냐에 따라 액션을 다르게 주면 해결 가능할 것 같습니다!
private func addTapGestureForCollectionView() {
let tap = UITapGestureRecognizer(target: self, action: #selector(didTapOutsideCollectionView))
self.dreamSearchCollectionView.addGestureRecognizer(tap)
}
@objc
private func didTapOutsideCollectionView(_ recognizer: UITapGestureRecognizer) {
let tapLocation = recognizer.location(in: self.dreamSearchCollectionView)
let indexPathForTap = dreamSearchCollectionView.indexPathForItem(at: tapLocation)
let tappedOutOfItems = indexPathForTap == nil
if let row = indexPathForTap?.row {
self.selectedIndex.accept(row)
} else {
self.view.endEditing(true)
}
}
Contributor
There was a problem hiding this comment.
이렇게 되면 collectionView의 select가 먹히지 않기 때문에 컬렉션뷰 딜리게이트 메서드는 삭제해도 될 것 같아요!
Member
Author
There was a problem hiding this comment.
오호 location의 index를 먼저 뽑아오는군요... 좋은 방법쓰... 적용하겠습니다아 👍
Contributor
|
추가로 수정이 필요한 부분이 보여서 남깁니다..! QA 보드에는 작성하지 않았어요~ @EunHee-Jeong
|
Suyeon9911
previously approved these changes
Jan 25, 2023
Member
Suyeon9911
left a comment
Suyeon9911
left a comment
There was a problem hiding this comment.
수고하셨습니다 !! CollectionView를 2번 탭해서 인식해주는 방식도 있겠지만, 사용자가 의도한 바를 모를 가능성이 크다고 생각합니다. 또한, 어떤 경우에는 의도하지 않은대로 동작할 가능성도 있어보이구요.. !! 준호 님이 말씀하신대로 selected된 인덱스를 받을 경우엔 상세보기로 이동하고 그 외의 경우를 분기처리해서 키보드를 내려주면 될 것 같아요 !~~
L-j-h-c
previously approved these changes
Jan 25, 2023
| let tap = UITapGestureRecognizer(target: self, action: #selector(didTapOutsideCollectionView)) | ||
| tap.numberOfTapsRequired = 2 | ||
| tap.numberOfTapsRequired = 1 | ||
| self.dreamSearchCollectionView.addGestureRecognizer(tap) |
Suyeon9911
previously approved these changes
Jan 26, 2023
Suyeon9911
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
🎤 PR Point
📮 관련 이슈