Merged
Conversation
L-j-h-c
approved these changes
Jan 20, 2023
Comment on lines
+221
to
+227
| self.genreStackView.subviews.forEach { (view) in | ||
| view.removeFromSuperview() | ||
| } | ||
|
|
||
| tag.forEach { | ||
| genreStackView.addArrangedSubview(DreamGenreTagView(type: .home, genre: $0)) | ||
| } |
Comment on lines
+102
to
114
| subScrollView.snp.makeConstraints { | ||
| $0.top.equalTo(titleLabel.snp.bottom).offset(Metric.noteLabelTop) | ||
| $0.leading.equalToSuperview() | ||
| $0.leading.trailing.bottom.equalToSuperview() | ||
| } | ||
|
|
||
| contentView.snp.makeConstraints { | ||
| $0.edges.equalToSuperview() | ||
| $0.width.equalTo(subScrollView.snp.width) | ||
| } | ||
|
|
||
| noteLabel.snp.makeConstraints { | ||
| $0.edges.equalToSuperview() | ||
| } |
Contributor
There was a problem hiding this comment.
scrollView를 이용해 깔끔하게 잡아주셨군요...! textView를 사용하는 방법도 있을 것 같슴당~
EunHee-Jeong
approved these changes
Jan 21, 2023
Comment on lines
+249
to
+262
| private func resetHomeLayoutIfNotEmpty() { | ||
| dreamCardCollectionView.setContentOffset(CGPoint(x: 0, y: 0), animated: true) | ||
|
|
||
| [self.desciptionLabel, self.dreamCardCollectionView].forEach { | ||
| $0.isHidden = false | ||
| } | ||
|
|
||
| welcomeLabel.snp.remakeConstraints { | ||
| $0.top.equalTo(logoView.snp.bottom).offset(Metric.mainLabelTop) | ||
| $0.leading.equalToSuperview().inset(Metric.mainLabelLeading) | ||
| } | ||
|
|
||
| self.emptyLabel.removeFromSuperview() | ||
| } |
Comment on lines
-234
to
+206
| self.setCollectionViewAdapter() | ||
| resetHomeLayoutIfNotEmpty() | ||
| self.dreamCardCollectionView.reloadData() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
1차 QA 이슈들 수정 완료 !
🎤 PR Point
저번 PR에서 남겨주신 코드리뷰 반영하였습니다 !! 어떻게 해결했는지 코멘트 남길게요.
코드를 짰을 당시에 집중을 안했었나봐요.. 엉망진창이네.. 그때 코드리뷰 피드백 남겨주신 것처럼
📮 관련 이슈