[Fix] #115 - QA 1차 반영#123
Merged
EunHee-Jeong merged 10 commits intoTeamRecorDream:developfrom Jan 15, 2023
Merged
Conversation
added 8 commits
January 10, 2023 16:23
EunHee-Jeong
added
으니짱 🍅
L-j-h-c
previously approved these changes
Jan 14, 2023
Contributor
L-j-h-c
left a comment
L-j-h-c
left a comment
There was a problem hiding this comment.
수고하셨습니다!!
전체 뷰의 배경색이 컬렉션뷰의 배경색과 다른 것 같은데 수정 부탁드려요~!
그리고 스티키 헤더로 구현해서 아래 방향으로 스크롤 했을 때 헤더가 잠깐 떼졌다가 붙는 모습이 조금 부자연스러워 보여서... 필터에 footer로 넣거나 두번째 컬렉션뷰의 bounce를 false로 두는 것이 어떤지 제안드립니다!
Comment on lines
+54
to
+57
| input.viewWillAppear.subscribe(onNext: { _ in | ||
| self.useCase.execute(requestValue: .init(filterType: 0)) | ||
| output.loadingStatus.accept(true) | ||
| }).disposed(by: disposeBag) |
Contributor
There was a problem hiding this comment.
viewWillAppear에서 항상 데이터를 갱신하도록 기획이 수정되었나요?
Member
Author
There was a problem hiding this comment.
다른 탭으로 이동했다 다시 돌아오는 경우에 뷰를 초기화해야 하는데, 적절한 방법이 떠오르지 않아 viewWillAppear → 전체 fetch 코드를 추가하였습니다...!
L-j-h-c
approved these changes
Jan 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
filter,storage두 개로 나누어 구성하였습니다.stickyHeader로 바꾸었습니다.🎤 PR Point
📸 스크린샷
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-14.at.13.28.45.mp4
📮 관련 이슈