[Fix] #111 - 1차 QA 반영#122
Merged
L-j-h-c merged 12 commits intoTeamRecorDream:developfrom Jan 15, 2023
Merged
Conversation
EunHee-Jeong
approved these changes
Jan 15, 2023
Member
EunHee-Jeong
left a comment
EunHee-Jeong
left a comment
There was a problem hiding this comment.
잘 보고 갑니다 !! QA 리스트 은근 많았는데 넘 수고하셨어욤 👍
| @@ -437,7 +461,7 @@ extension DreamWriteVC { | |||
| private func dismissVoiceRecordView() { | |||
Member
There was a problem hiding this comment.
dismiss를 직접 구현한거는 첨 보는데 신기하네유...
Comment on lines
+211
to
+214
| recordView.dismiss.subscribe(onNext: { [weak self] in | ||
| guard let self = self else { return } | ||
| self.dismissVoiceRecordView() | ||
| }).disposed(by: self.disposeBag) |
Member
There was a problem hiding this comment.
여기서 쓰려고 위에서 Observable들을 먹여준거였군...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
🎤 PR Point
공통
작성하기, 수정하기
마이페이지
📮 관련 이슈