Skip to content

[Fix] #113 - 1차 QA를 위한 hotfix : 토큰 재발급 기능 적용, 탭바 사이즈 조절#114

Merged
L-j-h-c merged 2 commits intoTeamRecorDream:developfrom
L-j-h-c:fix/#113-tokenReissuanceTabbar
Jan 10, 2023
Merged

[Fix] #113 - 1차 QA를 위한 hotfix : 토큰 재발급 기능 적용, 탭바 사이즈 조절#114
L-j-h-c merged 2 commits intoTeamRecorDream:developfrom
L-j-h-c:fix/#113-tokenReissuanceTabbar

Conversation

@L-j-h-c
Copy link
Copy Markdown
Contributor

@L-j-h-c L-j-h-c commented Jan 8, 2023

👻 작업한 내용

🎤 PR Point

  • 토큰 재발급 기능 적용
  • 보관함 바인딩 오류 일부 수정 : 마이페이지를 누르면 여러번 push됩니다.
  • 탭바 사이즈 미세 조정

📮 관련 이슈

@L-j-h-c L-j-h-c added the fix 버그를 수정합니다. label Jan 8, 2023
@L-j-h-c L-j-h-c self-assigned this Jan 8, 2023
Copy link
Copy Markdown
Member

@EunHee-Jeong EunHee-Jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인이요!! LGTM

Comment on lines +46 to +51
// body가 존재하면 갱신
guard let body = decodedData.data else { return completion(false) }
DefaultUserDefaultManager.set(value: body.accessToken, keyPath: .accessToken)
DefaultUserDefaultManager.set(value: body.refreshToken, keyPath: .refreshToken)

return completion(true)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

토큰 유효하지 않음 -> 바디 검사 -> 없으면 false, 있으면 DefaultUserDefaultManager에 넣고 true
굿굿!

Comment on lines -58 to +60
self.bindViews()
self.bindViewModels()
self.dreamStorageCollectionView.reloadData()
self.resetView()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복 구독 주의해야겠다...

Copy link
Copy Markdown
Member

@Suyeon9911 Suyeon9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !!

@L-j-h-c L-j-h-c merged commit efc0aca into TeamRecorDream:develop Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그를 수정합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 테스트플라이트 업로드를 위한 hotfix - 토큰 재발급 처리, 탭바 디자인 미세 수정,

3 participants