[Fix] #109 - 수정하기 순환 참조 문제 해결 & 저장 버튼 활성화 로직 수정#110
Merged
L-j-h-c merged 2 commits intoTeamRecorDream:developfrom Jan 8, 2023
Merged
[Fix] #109 - 수정하기 순환 참조 문제 해결 & 저장 버튼 활성화 로직 수정#110L-j-h-c merged 2 commits intoTeamRecorDream:developfrom
L-j-h-c merged 2 commits intoTeamRecorDream:developfrom
Conversation
EunHee-Jeong
approved these changes
Jan 8, 2023
| override func prepareForReuse() { | ||
| super.prepareForReuse() | ||
| self.disposeBag = DisposeBag() | ||
| } |
Suyeon9911
reviewed
Jan 8, 2023
Comment on lines
-265
to
+275
| dataSource = UICollectionViewDiffableDataSource<Section, AnyHashable>(collectionView: dreamWriteCollectionView, cellProvider: { collectionView, indexPath, itemIdentifier in | ||
| dataSource = UICollectionViewDiffableDataSource<Section, AnyHashable>(collectionView: dreamWriteCollectionView, cellProvider: { [weak self] collectionView, indexPath, itemIdentifier in | ||
| guard let self = self else { return UICollectionViewCell() } | ||
| switch Section.type(indexPath.section) { | ||
| case .main: | ||
| self.mainCell = nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 작업한 내용
수정하기 뷰에서 순환 참조로 인해 기존 셀이 메모리에서 해제되지 않던 문제를 해결했습니다.
수정하기 API가 정상 작동하게 수정했습니다.
📮 관련 이슈