Skip to content

Update SoundCloud clientId and fix YouTube tests #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 9 commits into from
Dec 11, 2021
Merged

Update SoundCloud clientId and fix YouTube tests #760

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f735788
Fixed Soundcloud hardcoded client id
litetex Dec 8, 2021
3c669d3
Fixed YoutubeStreamExtractorAgeRestrictedTest
litetex Dec 8, 2021
652fdf2
Updated mock-data for YoutubeStreamExtractorAgeRestrictedTest
litetex Dec 8, 2021
7f99c1c
Fixed YoutubeStreamExtractorLivestreamTest
litetex Dec 8, 2021
f276bac
Fixed SoundcloudStreamExtractorTest
litetex Dec 8, 2021
75bb83a
Fixed YoutubeChannelExtractorTest
litetex Dec 8, 2021
5c288eb
Updated mock data for YoutubeChannelExtractorTest
litetex Dec 8, 2021
a3a0c1e
Fixed YoutubeCommentsExtractorTest
litetex Dec 8, 2021
d9b2a20
Updated mock data for YoutubeCommentsExtractorTest
litetex Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...c/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
import static org.schabi.newpipe.extractor.utils.Utils.*;

public class SoundcloudParsingHelper {
private static final String HARDCODED_CLIENT_ID =
"nGKlrpy2IotLQ0QGwBOmIgSFayis6H4e"; // Updated on 04/11/21
static final String HARDCODED_CLIENT_ID =
"1NKODbzHzEpoowFHxTAmS7oB08DObPuK"; // Updated on 08/12/21
private static String clientId;
public static final String SOUNDCLOUD_API_V2_URL = "https://api-v2.soundcloud.com/";

Expand Down
12 changes: 12 additions & 0 deletions ...st/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,13 @@
import org.junit.Test;
import org.schabi.newpipe.downloader.DownloaderTestImpl;
import org.schabi.newpipe.extractor.NewPipe;
import org.schabi.newpipe.extractor.exceptions.ExtractionException;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

import java.io.IOException;

public class SoundcloudParsingHelperTest {
@BeforeClass
public static void setUp() {
Expand All @@ -20,6 +24,14 @@ public void assertThatHardcodedClientIdIsValid() throws Exception {
SoundcloudParsingHelper.checkIfHardcodedClientIdIsValid());
}

@Test
public void assertHardCodedClientIdMatchesCurrentClientId() throws IOException, ExtractionException {
assertEquals(
"Hardcoded client doesn't match extracted clientId",
SoundcloudParsingHelper.HARDCODED_CLIENT_ID,
SoundcloudParsingHelper.clientId());
}

@Test
public void resolveUrlWithEmbedPlayerTest() throws Exception {
Assert.assertEquals("https://soundcloud.com/trapcity", SoundcloudParsingHelper.resolveUrlWithEmbedPlayer("https://api.soundcloud.com/users/26057743"));
Expand Down