Extract Video Short Description in YouTube.#731
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom Oct 15, 2021
Merged
Conversation
In Trending, and Search results.
FireMasterK
added
enhancement
Stypox
previously approved these changes
Sep 27, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I had a doubt about returning null or an empty string when there is no short description, but by looking at other extractors there doesn't seem to be a consistent way to do it, so it is ok like this.
Code looks good, thank you!
AudricV
previously requested changes
Sep 27, 2021
Member
AudricV
left a comment
AudricV
left a comment
There was a problem hiding this comment.
Just some code style issues and this can be merged.
...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java
Outdated
Show resolved
Hide resolved
litetex
requested changes
Oct 3, 2021
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com> Add final. Co-authored-by: TiA4f8R <74829229+TiA4f8R@users.noreply.github.com>
FireMasterK
force-pushed
the
short-description
branch
from
34525fe to
6231396
Compare
This was referenced Nov 30, 2021
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Trending, and Search results.
A test wasn't added for trending, since not all videos have descriptions.
Closes #726