Merged
Conversation
Contributor
Author
|
|
5 tasks
TobiGr
force-pushed
the
user-agent
branch
3 times, most recently
from
5fac4b7 to
92f420d
Compare
TobiGr
force-pushed
the
user-agent
branch
3 times, most recently
from
f1dbf5a to
eff3b5e
Compare
Implement a max number of requests per minute to prevent hitting reate limits and triggering ReCaptchaExceptions. This slows down the RecordingDownloader significantly and can be adjusted if needed. A request ist retried once when facing a ReCaptchaException.
Stypox
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the user agent used for testing purposes to a modern version.
This also modifies the RecordingDownloader to automatically prevent hitting rate limits ("sign in to confirm you are not a bot") + RecaptchaExceptions and handle them if they occur: There is now a max number of requests which are made per minute (default is 30). Requests are postponed if the limit is reached. When running into a RecaptchaException the RecordingDownloader waits between 35 and 60 seconds before retrying the request once again. This slows down the time for generating new mocks to ~5 minutes but prevents faulty mocks.
Warning
All YouTube tests passing the real tests also pass the new mock tests. However, the Bandcamp tests are failing locally now. Bandcamp tests run by GH Actions pass however.