Fixed a bug that prevented the display of multiple empty playlists#9642
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Jan 13, 2023
Merged
Conversation
AudricV
added
bug
|
Kudos, SonarCloud Quality Gate passed!
|
Stypox
approved these changes
Jan 13, 2023
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! I can confirm it works :-)
dustdfg
added a commit
to dustdfg/NewPipe
that referenced
this pull request
Jan 14, 2026
Turned out this bug was already fixed two years ago but unfortunately it made its way back again. It was solved in TeamNewPipe#9642 but back then another method was used for querying playlists from db (for add playlist dialog) then in ef4a623 was introduced another method which had the same problem as fixed in TeamNewPipe#9642 and which eventually replaced original method in code for querying playlists from db (for add playlist dialog)
3 tasks
dustdfg
added a commit
to dustdfg/NewPipe
that referenced
this pull request
Jan 15, 2026
Turned out this bug was already fixed two years ago but unfortunately it made its way back again. It was solved in TeamNewPipe#9642 but back then another method was used for querying playlists from db (for add playlist dialog) then in ef4a623 was introduced another method which had the same problem as fixed in TeamNewPipe#9642 and which eventually replaced original method in code for querying playlists from db (for add playlist dialog)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
getPlaylistMetadata:If a playlist has no streams, there won’t be any rows in the
PLAYLIST_STREAM_JOIN_TABLEtable that have a foreign key to that playlist. Thus, theJOIN_PLAYLIST_IDwill not have a corresponding value in any rows of the join table. So, if you group by theJOIN_PLAYLIST_ID, only playlists that contain videos are grouped and displayed.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence