Conversation
|
You might have had some rebasing issues, since some of the changes are unrelated and undo some details of #8153 |
AudricV
added
the
player
TacoTheDank
force-pushed
the
bumpExoPlayer
branch
from
e51dbed to
0a59947
Compare
I always keep my branches up-to-date; it simply looks like some PRs were merged while I was initially making this PR. No rebasing issues here! I have updated the PR. All changes in this PR are to fix new ExoPlayer deprecations. I have double checked them to be sure. I have also updated the YoutubeHttpDataSource note to 2.18.0 (there were no real changes in upstream). Just as a note, this class will need to be kept up-to-date with future upstream changes if (and inevitably when) they occur. |
TacoTheDank
force-pushed
the
bumpExoPlayer
branch
from
0a59947 to
1404581
Compare
|
thank you for the PR! Please make sure that we opt out of the diagnostics with ExoPlayer.Builder.setUsePlatformDiagnostics(false) around line 515 |
|
Done 👍 |
|
Kudos, SonarCloud Quality Gate passed! |
Redirion
left a comment
Redirion
left a comment
There was a problem hiding this comment.
Tested Play, Pause, Mediabutton, Subtitles. Looks all good to me. Thanks again
app/src/main/java/org/schabi/newpipe/player/datasource/YoutubeHttpDataSource.java
Show resolved
Hide resolved
|
Will this be a potential issue?: google/ExoPlayer#10381 |
|
It could, but we will probably have time to update to the next version before the next NewPipe release, so it shouldn't be a problem. |
|
Mm, hopefully. |
5 participants
What is it?
Description of the changes in your PR
I tested on my device and everything seemed to work fine. Feel free to test yourselves, though.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence