Fix handling exception in playOnPopup and toggle description tab#7056
Fix handling exception in playOnPopup and toggle description tab#7056TobiGr merged 4 commits intorelease/0.21.10from
playOnPopup and toggle description tab#7056Conversation
litetex
left a comment
litetex
left a comment
There was a problem hiding this comment.
Code looks good to me
How can I test these changes? E.g. the popup error?
I'm pretty sure this PR fixes also multiple issues.
Could please link them in the description of the PR?
|
You can follow the steps provided in our Matrix channel.
Only found one, I guess the others were closed as duplicates. The other |
…minimized player in VideoDetailFragment The comments tab was updated although the settings for the description tab were changed.
TobiGr
force-pushed
the
fix/playOnPopup
branch
from
81d1419 to
ce8c2bf
Compare
|
Fixed the |
app/src/main/java/org/schabi/newpipe/util/external_communication/InternalUrlsHandler.java
Outdated
Show resolved
Hide resolved
|
Test looks good, works like a charm :) |
…server() Hopefully also fix the cause of the original error.
TobiGr
force-pushed
the
fix/playOnPopup
branch
from
ce8c2bf to
4d51ebc
Compare
|
Why didn't it close the issues linked to it? |
|
No idea. Anyway, that issue is still not solved, apparently, so it needs to stay open. |
5 participants
What is it?
Description of the changes in your PR
OnErrorNotImplementedExceptioninInternalUrlsHandler.playOnPopupby implementing error handling. A popup is shown with a little info on the error:OnErrorNotImplementedExceptioninSearchFragment.initSuggestionObserver(). Errors are reported in the snackbar now. Not sure if I also managed to fix the cause of the original error. This needs to be investigated.Fixes issues
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence