Added darker splash screen for OS dark theme

[sauravrao637]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

added night value in res for Opening Theme
added splash_background_night

Before/After Screenshots/Screen Record

• Before: Bright launch screen even when using dark mode system wide
• After: Now it's darker :)

Fixes the following issue(s)

• Fixes Darker splash screen for system wide night mode #7048

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[sauravrao637]

@opusforlife2 how does the darker splash screen looks?

[opusforlife2]

@sauravrao637 Well, I would need before/after screenshots to compare. Please add them to the description, since this is a UI change. But if it's the same dark red colour as the app, then I think it would look great. That's the colour I was expecting the splash screen to be after your earlier PR.

(Though I did fantasise for a moment about a dark shadowed Newpipe icon on a dark grey background, to be honest.)

[sauravrao637]

@opusforlife2 Yup it's the same dark color, we can make it black or dark grey as well , what do you think will be better?

[tsiflimagas]

I like the colour, but is it possible to make it follow the app's theme (or if you intended to do it so, is it possible to fix it?).

[triallax]

@tsiflimagas that's not possible unfortunately, see #6244 (comment).

[tsiflimagas]

@mhmdanas oh, I see, thank you. No problem then :)

[opusforlife2]

@sauravrao637 I think the current colour is fine for this PR. If you have some spare time later, we could experiment with colours in a new issue. :D

[opusforlife2]

@sauravrao637 You put the code changes as the PR title again. :P

Edited.