Use custom cancel string everywhere#6848
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Aug 22, 2021
Merged
Conversation
to fix missing somali translation for android.R.string.cancel
triallax
added
bug
TobiGr
approved these changes
Aug 5, 2021
Contributor
|
@Stypox thank you for doing this |
Contributor
|
@Stypox could you please do the same for "OK" string which is translated in all languages but is stuck English in some places?? |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR replaces every occourrence of
android.R.string.cancelwithR.string.cancel(which was already being translated and used in other places). Theandroid.R.string.cancelcould not be used since it is missing translation in some languages, like Somali.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence