Conversation
Lossless compression.
|
What is the APK size difference? |
|
@Stypox I'll check and come back with the results. |
|
I built a release APK for each of this PR's commit and the previous commit. This PR's APK is 8904298 bytes long, while the previous APK is 8906273 bytes long, a difference of around 2 kilobytes. |
triallax
left a comment
There was a problem hiding this comment.
I believe it may not be worth it to minify anything not included in the APK, as I believe it would increase the Git repo's size, as Git does not store diffs of binary files (correct me if I'm wrong though).
|
Minimizing the screenshots makes sense to me, because that results in faster loading of the readme |
Also to me, I'd merge this |
|
@RDKRACZ thanks! |
Lossless compression.
What is it?
Description of the changes in your PR
Lossless compression. I used oxipng.
Before/After Screenshots/Screen Record
No visual differences
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence