Skip to content

Allow manual execution of ci workflow#6809

Merged
triallax merged 1 commit intoTeamNewPipe:devfrom
litetex:ci-run-allow-manual-run-of-workflows
Aug 4, 2021
Merged

Allow manual execution of ci workflow#6809
triallax merged 1 commit intoTeamNewPipe:devfrom
litetex:ci-run-allow-manual-run-of-workflows

Conversation

@litetex
Copy link
Copy Markdown
Member

@litetex litetex commented Jul 30, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

As mentioned in #6709 (comment):

  • Is something speaking against adding workflow_dispatch: by default to the CI workflow?
    If I do these kinds of PR, I always have to add it manually and change the default branch of my fork.
    Shouldn't do any harm in theory.
    If nothing speaks against it I will open a PR.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex marked this pull request as ready for review July 30, 2021 19:53
@Stypox
Copy link
Copy Markdown
Member

Stypox commented Jul 31, 2021

Is there a demo I can try (even on another repo, I just have no idea how the "manual execution" would be triggered)?

@triallax
Copy link
Copy Markdown
Contributor

@Stypox you would go to the Actions tab, select a workflow from the left, and then there would be a run workflow button.

Screenshot of run workflow button

@triallax triallax added CI Everything related to CI (Continuous integration) feature request Issue is related to a feature in the app labels Jul 31, 2021
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then this looks good in my opinion

@triallax triallax merged commit 12e46e0 into TeamNewPipe:dev Aug 4, 2021
@litetex litetex deleted the ci-run-allow-manual-run-of-workflows branch August 4, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Everything related to CI (Continuous integration) feature request Issue is related to a feature in the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants