Add checkstyle rule to show final local variable violations as warning#4138
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Aug 16, 2020
Merged
Add checkstyle rule to show final local variable violations as warning#4138TobiGr merged 2 commits intoTeamNewPipe:devfrom
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
wb9688
requested changes
Aug 16, 2020
wb9688
force-pushed
the
checkstyle_final
branch
from
f7bfe9c to
8722867
Compare
wb9688
approved these changes
Aug 16, 2020
Contributor
|
Happy rebasing to everyone!? |
Member
|
@TobiGr: I guess so… ¯\_(ツ)_/¯ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Add checkstyle rule to check for final local variable violations.
Since fixing everything at once would be very bothersome, it is shown as warning and not error. Instead it can be gradually fixed when someone touches the files.
The reason i want it is, that on every PR one has to manually search for the violations.
Doc: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.html
Agreement