Add need for contributors to discuss possible changes#4126
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Aug 15, 2020
gkeegan:contributor-discussions
Merged
Add need for contributors to discuss possible changes#4126TobiGr merged 1 commit intoTeamNewPipe:devfrom gkeegan:contributor-discussions
TobiGr merged 1 commit intoTeamNewPipe:devfrom
gkeegan:contributor-discussions
Conversation
This was discussed in IRC, and should help prevent the occurrence of problems where people spend hours on a feature only for it to be rejected for miscellaneous reasons.
Stypox
approved these changes
Aug 15, 2020
TobiGr
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Fixes the following issue(s)
As discussed on IRC, prevent the occurrence of problems where people spend hours on a feature only for it to be rejected for miscellaneous reasons.
Agreement
I did not follow the style for linebreaks since I couldn't figure out where they go. Please suggest changes to add them if they are necessary.