Merged
Conversation
* ReCaptchas are implemented using a simple WebView with Javascript enable.
* All HTTP responses inside the WebView are catched (using onPageFinished())
** When Google reCatcha cookies are detected, register cookies to the
Downloader class and Return to MainActivity
* Fix typo setSearchWorkerResultListner to setSearchWorkerResultListener
Member
|
I was not able to test it correctly since I never had the case where I had to enter a captcha. Can you enter some screenshots, to see how it would look like :) |
Contributor
Author
|
Hi, Sure :
But there is still two issues with this pull request that i need to fix :
Do you plan to work on NewPipe at the 33c3 ? I will be there too :) |
Member
|
Well why not :) Meet me at the NewPipe talk, so we can talk about that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following patches try to implement reCaptcha from Youtube in a simple manner :
If HTTP 429 is returned by Downloader : reCaptchaException is thrown and reCatpchaAcitivity is started.
The Activity is a simple WebView (with Javascript enabled) displaying reCaptcha.
Ref #386 .