Skip to content

Correctly retrieve menu item inside download dialog#13290

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
dustdfg:correct_download_fragment
Feb 25, 2026
Merged

Correctly retrieve menu item inside download dialog#13290
TobiGr merged 1 commit intoTeamNewPipe:devfrom
dustdfg:correct_download_fragment

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Feb 25, 2026

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

  • Correctly retrieve menu item inside download dialog

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Feb 25, 2026
@TobiGr TobiGr added bug Issue is related to a bug downloader Issue is related to the downloader labels Feb 25, 2026
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@TobiGr TobiGr enabled auto-merge February 25, 2026 23:37
@TobiGr TobiGr merged commit dd65db5 into TeamNewPipe:dev Feb 25, 2026
7 checks passed
@ShareASmile ShareASmile added the regression A bug that didn't exist in prior versions but appeared after a certain change label Feb 27, 2026
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug downloader Issue is related to the downloader regression A bug that didn't exist in prior versions but appeared after a certain change size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attempt to download leads to crash

3 participants