Skip to content

Convert ErrorActivity to kotlin#13225

Merged
theimpulson merged 5 commits intoTeamNewPipe:devfrom
dustdfg:error_activity_kotlin
Feb 11, 2026
Merged

Convert ErrorActivity to kotlin#13225
theimpulson merged 5 commits intoTeamNewPipe:devfrom
dustdfg:error_activity_kotlin

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Feb 10, 2026

What is it?

  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Convert ErrorActivity to kotlin

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Feb 10, 2026
Copy link
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please strip commit addressing new line to another PR and open that when this one is merged. It makes things harder to review otherwise.

@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 10, 2026

Please strip commit addressing new line to another PR and open that when this one is merged. It makes things harder to review otherwise.

Ok. And sorry expect kotlin conversion commit to be changed because I've just found kotlins extension functions appendLine and buildString... Or I can add one more commit on top

@theimpulson
Copy link
Member

Please strip commit addressing new line to another PR and open that when this one is merged. It makes things harder to review otherwise.

Ok. And sorry expect kotlin conversion commit to be changed because I've just found kotlins extension functions appendLine and buildString... Or I can add one more commit on top

It should be okay to amend existing commits or add another on top as long as they are related and aren't too big of a change.

@dustdfg dustdfg force-pushed the error_activity_kotlin branch from f6c4e86 to a51c555 Compare February 10, 2026 09:07
@github-actions github-actions bot added size/large PRs with less than 750 changed lines and removed size/giant PRs with more than 750 changed lines labels Feb 10, 2026
@dustdfg dustdfg force-pushed the error_activity_kotlin branch from a51c555 to 5ef74d5 Compare February 10, 2026 12:47
@dustdfg dustdfg marked this pull request as draft February 10, 2026 21:36
@dustdfg dustdfg marked this pull request as ready for review February 10, 2026 21:36
@theimpulson theimpulson force-pushed the error_activity_kotlin branch from 5ef74d5 to c3dbed5 Compare February 11, 2026 13:41
@theimpulson
Copy link
Member

Thanks!

@theimpulson theimpulson merged commit 8d45b6b into TeamNewPipe:dev Feb 11, 2026
5 checks passed
@Stypox
Copy link
Member

Stypox commented Feb 11, 2026

@dustdfg in case you or anyone else wants to convert the whole error infrastructure to Kotlin and rewrite the UI in Compose on the refactor branch, I would suggest copy pasting files from here: https://github.com/Stypox/dicio-android/tree/master/app/src/main/kotlin/org/stypox/dicio/error . It's a port of NewPipe's error activity to Compose I made a while ago that looks almost the same and has roughly the same functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants