Skip to content

FeedLoadManager: Shuffle the order outdated subscriptions are updated in#13161

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
jpds:outdated-subscription-shuffle
Feb 6, 2026
Merged

FeedLoadManager: Shuffle the order outdated subscriptions are updated in#13161
TobiGr merged 1 commit intoTeamNewPipe:devfrom
jpds:outdated-subscription-shuffle

Conversation

@jpds
Copy link
Contributor

@jpds jpds commented Jan 31, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Shuffle the order outdated subscriptions are updated in FeedLoadManager

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jan 31, 2026
@dustdfg
Copy link
Contributor

dustdfg commented Jan 31, 2026

What is the need to do it? You expect something like youtube to be less suspicious seeing random order?

@jpds
Copy link
Contributor Author

jpds commented Jan 31, 2026

@dustdfg Indeed so, it was odd watching the my last subscriptions in the popup notification in the exact order I had subscribed to them.

And it's less about suspiciousness and more to do with being less easy to fingerprint a user.

@TobiGr
Copy link
Contributor

TobiGr commented Jan 31, 2026

Please add that intention as a comment so that your change is nit removed later

@jpds jpds force-pushed the outdated-subscription-shuffle branch from a4ecf9f to ae60f7d Compare January 31, 2026 20:48
@jpds
Copy link
Contributor Author

jpds commented Jan 31, 2026

@TobiGr Done

@TobiGr TobiGr added the privacy & data protection Issues regarding either NewPipe, Team NewPipe services or external services NewPipe uses label Jan 31, 2026
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@TobiGr TobiGr merged commit 56a0436 into TeamNewPipe:dev Feb 6, 2026
5 checks passed
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

privacy & data protection Issues regarding either NewPipe, Team NewPipe services or external services NewPipe uses size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants