Partial revert: fix VideoDetailFragment flickering#13132
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Jan 28, 2026
Merged
Partial revert: fix VideoDetailFragment flickering#13132Stypox merged 1 commit intoTeamNewPipe:devfrom
Stypox merged 1 commit intoTeamNewPipe:devfrom
Conversation
This partially reverts commit 92a07a3, which was needed to fix ghost notifications. There I broke the "cycle" causing the useless notifications to popup in 2 different places (see points 3 and 4 of the commit description). However, breaking the cycle in point 4 ("`PlayerHolder::tryBindIfNeeded()` is now used to passively try to bind, instead of `PlayerHolder::startService()`" was not correct, for the following reason. I assumed that `ACTION_PLAYER_STARTED` was used for notifying that the player was instantiated anew, while it actually is used to notify that something is now ready for use: it could be the player, but it could also just be that the bottom sheet view was just added and thus the VideoDetailFragment needs to start the player. Therefore, when handling `ACTION_PLAYER_STARTED` it is correct to start the player service and not just try to bind to it. The other point in which I broke the cycle (point 3) should still prevent ghost notifications, although I could not test.
This was referenced Jan 27, 2026
7 tasks
ShareASmile
added
bug
dustdfg
added a commit
to dustdfg/NewPipe
that referenced
this pull request
Feb 16, 2026
Refacor port of: 5155b24 Look at TeamNewPipe#13132 for more details
4 tasks
absurdlylongusername
added a commit
that referenced
this pull request
Feb 19, 2026
…kers-refactor Backport #13132 to refactor branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
This partially reverts commit 92a07a3 in #12606, which was needed to fix ghost notifications (#12489). There I broke the "cycle" causing the useless notifications to popup in 2 different places (see points 3 and 4 of the commit description). However, breaking the cycle in point 4 ("
PlayerHolder::tryBindIfNeeded()is now used to passively try to bind, instead ofPlayerHolder::startService()") was not correct, for the following reason. I assumed thatACTION_PLAYER_STARTEDwas used for notifying that the player was instantiated anew, while it actually is used to notify that something is now ready for use: it could be the player, but it could also just be that the bottom sheet view was just added and thus the VideoDetailFragment needs to start the player. Therefore, when handlingACTION_PLAYER_STARTEDit is correct to start the player service and not just try to bind to it. The other point in which I broke the cycle (point 3) should still prevent ghost notifications, although I could not test.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence