Commit all the playlist changes to db immediately#13005
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Jan 5, 2026
Merged
Commit all the playlist changes to db immediately#13005TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Conversation
+ some additional minor code cleanup in the file
TobiGr
added
database
TobiGr
approved these changes
Jan 5, 2026
dustdfg
commented
Jan 12, 2026
Comment on lines
768
to
772
| final boolean isSwapped = itemListAdapter.swapItems(sourceIndex, targetIndex); | ||
| if (isSwapped) { | ||
| debounceSaver.setHasChangesToSave(); | ||
| saveImmediate(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Causes #13040 but without it you can observe reordering if swap items in playlist before deleting duplicates...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence