Skip to content

Restore instance data in ImportConfirmationDialog before checking the data #13003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dustdfg wants to merge 1 commit into from
Closed

Restore instance data in ImportConfirmationDialog before checking the data #13003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,10 @@ public Dialog onCreateDialog(@Nullable final Bundle savedInstanceState) {
@Override
public void onCreate(@Nullable final Bundle savedInstanceState) {
super.onCreate(savedInstanceState);

Bridge.restoreInstanceState(this, savedInstanceState);
if (resultServiceIntent == null) {
throw new IllegalStateException("Result intent is null");
}
Comment on lines +52 to 55
Copy link
Copy Markdown
Contributor Author

@dustdfg dustdfg Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this check after it? We either set value via show method (100%) either it will be restored (from automatically stored state).

Is there any possibility that after we saved correct state (100%) in onCreate we will still receive null?


Bridge.restoreInstanceState(this, savedInstanceState);
}

@Override
Expand Down