Fix header crash while scrolling in a playlist or just after deleting a video in it

[whistlingwoods]

What is it?

• Bugfix (user facing)
• Feature (user facing) ⚠️ Your PR must target the refactor branch
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Fully implement Fix header crash in History list view #12214 by reapplying reverted commits 2abe71c and ab73dc1 which were thought not required at that point of time but actually they do fix the issue in local playlist fragment, removing the animation fixed the crash for history view only.

• Changes adapted from d3cd3d6 by @j-haldane

Fixes the following issue(s)

• Fixes Crash in lists (ViewHolder views not attached) #4475
• I have tested these changes for months and haven't experienced a single crash related to this bug as reported in a related comment here using playlist operations or otherwise.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.
• The proposed changes follow the AI policy.
• I tested the changes using an emulator or a physical device.

[Stypox]

Thank you! I was wondering whether this should be done also for footer, but it turns out that, while the footer View is always set, showFooter is always equal to false in local lists. So I am pushing a commit to add some @Deprecated and calling it a day, since I want to avoid touching code that works.

Here is the path for footer supplier

commit b759c91a147a662d30e938ed39834120cc12e75b
Merge: cea5dd474 f9ef7938b
Author: Stypox <stypox@pm.me>
Date:   Tue Jan 27 21:24:06 2026 +0100

    On pr12996: Use footerSupplier instead of footer (but useless since footer always invisible anyway)

diff --cc app/src/main/java/org/schabi/newpipe/local/BaseLocalListFragment.java
index 00a721bcf,00a721bcf..af22c814b
--- a/app/src/main/java/org/schabi/newpipe/local/BaseLocalListFragment.java
+++ b/app/src/main/java/org/schabi/newpipe/local/BaseLocalListFragment.java
@@@ -138,7 -138,7 +138,7 @@@ public abstract class BaseLocalListFrag
              itemListAdapter.setHeaderSupplier(listHeaderSupplier);
          }
          footerRootBinding = getListFooter();
--        itemListAdapter.setFooter(footerRootBinding.getRoot());
++        itemListAdapter.setFooterSupplier(footerRootBinding::getRoot);
  
          itemsList.setAdapter(itemListAdapter);
      }
diff --cc app/src/main/java/org/schabi/newpipe/local/LocalItemListAdapter.java
index 3bb84e2de,3bb84e2de..7e4c78256
--- a/app/src/main/java/org/schabi/newpipe/local/LocalItemListAdapter.java
+++ b/app/src/main/java/org/schabi/newpipe/local/LocalItemListAdapter.java
@@@ -90,7 -90,7 +90,7 @@@ public class LocalItemListAdapter exten
  
      private boolean showFooter = false;
      private Supplier<View> headerSupplier = null;
--    private View footer = null;
++    private Supplier<View> footerSupplier = null;
      private ItemViewMode itemViewMode = ItemViewMode.LIST;
      private boolean useItemHandle = false;
  
@@@ -126,12 -126,12 +126,12 @@@
          if (DEBUG) {
              Log.d(TAG, "addItems() after > offsetStart = " + offsetStart + ", "
                      + "localItems.size() = " + localItems.size() + ", "
--                    + "header = " + hasHeader() + ", footer = " + footer + ", "
++                    + "header = " + hasHeader() + ", footer = " + hasFooter() + ", "
                      + "showFooter = " + showFooter);
          }
          notifyItemRangeInserted(offsetStart, data.size());
  
--        if (footer != null && showFooter) {
++        if (hasFooter() && showFooter) {
              final int footerNow = sizeConsideringHeader();
              notifyItemMoved(offsetStart, footerNow);
  
@@@ -199,14 -199,14 +199,18 @@@
          }
      }
  
--    public void setFooter(final View view) {
--        this.footer = view;
++    public void setFooterSupplier(@Nullable final Supplier<View> footerSupplier) {
++        this.footerSupplier = footerSupplier;
      }
  
      protected boolean hasHeader() {
          return this.headerSupplier != null;
      }
  
++    protected boolean hasFooter() {
++        return this.footerSupplier != null;
++    }
++
      public void showFooter(final boolean show) {
          if (DEBUG) {
              Log.d(TAG, "showFooter() called with: show = [" + show + "]");
@@@ -241,14 -241,14 +245,14 @@@
          if (hasHeader()) {
              count++;
          }
--        if (footer != null && showFooter) {
++        if (hasFooter() && showFooter) {
              count++;
          }
  
          if (DEBUG) {
              Log.d(TAG, "getItemCount() called, count = " + count + ", "
                      + "localItems.size() = " + localItems.size() + ", "
--                    + "header = " + hasHeader() + ", footer = " + footer + ", "
++                    + "header = " + hasHeader() + ", footer = " + hasFooter() + ", "
                      + "showFooter = " + showFooter);
          }
          return count;
@@@ -266,7 -266,7 +270,7 @@@
          } else if (hasHeader()) {
              position--;
          }
--        if (footer != null && position == localItems.size() && showFooter) {
++        if (hasFooter() && position == localItems.size() && showFooter) {
              return FOOTER_TYPE;
          }
          final LocalItem item = localItems.get(position);
@@@ -326,7 -326,7 +330,7 @@@
              case HEADER_TYPE:
                  return new HeaderFooterHolder(headerSupplier.get());
              case FOOTER_TYPE:
--                return new HeaderFooterHolder(footer);
++                return new HeaderFooterHolder(footerSupplier.get());
              case LOCAL_PLAYLIST_HOLDER_TYPE:
                  return new LocalPlaylistItemHolder(localItemBuilder, parent);
              case LOCAL_PLAYLIST_GRID_HOLDER_TYPE:
@@@ -381,8 -381,8 +385,8 @@@
          } else if (holder instanceof HeaderFooterHolder && position == 0 && hasHeader()) {
              ((HeaderFooterHolder) holder).view = headerSupplier.get();
          } else if (holder instanceof HeaderFooterHolder && position == sizeConsideringHeader()
--                && footer != null && showFooter) {
--            ((HeaderFooterHolder) holder).view = footer;
++                && hasFooter() && showFooter) {
++            ((HeaderFooterHolder) holder).view = footerSupplier.get();
          }
      }